[FLINK-4973] Let LatencyMarksEmitter use StreamTask's ProcessingTimeService #3008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, +1 |
|
Just for curiosity: I think that could have been solved also without extending the ProcessingTimeService for periodic tasks - each task could simply schedule its successor. |
|
True. The |
|
+1 to merge. |
|
Thanks for your review @rmetzger. Merging this PR. |
tillrohrmann
force-pushed
the
fixLatencyMarksEmitter
branch
3 times, most recently
from
b4ebab9 to
a2e8ff9
Compare
…ervice The LatencyMarksEmitter class uses now the StreamTask's ProcessingTimeService to schedule latency mark emission. For that the ProcessingTimeService was extended to have the method scheduleAtFixedRate to schedule repeated tasks. The latency mark emission is such a repeated task. This closes apache#3008.
tillrohrmann
force-pushed
the
fixLatencyMarksEmitter
branch
from
a2e8ff9 to
edaa6b5
Compare
joseprupi
pushed a commit
to joseprupi/flink
that referenced
this pull request
Feb 12, 2017
…ervice The LatencyMarksEmitter class uses now the StreamTask's ProcessingTimeService to schedule latency mark emission. For that the ProcessingTimeService was extended to have the method scheduleAtFixedRate to schedule repeated tasks. The latency mark emission is such a repeated task. This closes apache#3008.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LatencyMarksEmitter class uses now the StreamTask's ProcessingTimeService to schedule
latency mark emission. For that the ProcessingTimeService was extended to have the method
scheduleAtFixedRate to schedule repeated tasks. The latency mark emission is such a repeated
task.
cc @rmetzger.