-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-5519] [build] scala-maven-plugin version all change to 3.2.2 #3132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Good idea to upgrade the scala plugin. But with this change, it does not define a version at all. |
@StephanEwen There already is an entry for |
Okay, good. @rmetzger Any reservations that the upgrade to the Apache Parent POM v18 has implications on release scripts, etc? |
I think its fine (as long as we are not merging it to the 1.2 release branch) |
@StephanEwen There's no effect to the create_release_files.sh in my opinion. |
<plugin> | ||
<groupId>net.alchim31.maven</groupId> | ||
<artifactId>scala-maven-plugin</artifactId> | ||
<version>3.1.4</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you an not remove the version here. Where does the generated project get the plugin version from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have fix it. Thanks for review:)
d583bf6
to
2646dcf
Compare
Looks good, thanks. merging this... |
General
Documentation
Tests & Build
mvn clean verify
has been executed successfully locally or a Travis build has passed