Skip to content

Conversation

shijinkui
Copy link
Contributor

  1. scala-maven-plugin version all change to 3.2.2 in all module
  2. parent pom version change to apache-18 from apache-14
  • General

    • The pull request references the related JIRA issue ("[FLINK-5519] scala-maven-plugin version all change to 3.2.2")
    • The pull request addresses only one issue
    • Each commit in the PR has a meaningful commit message (including the JIRA id)
  • Documentation

    • Documentation has been added for new functionality
    • Old documentation affected by the pull request has been updated
    • JavaDoc for public methods has been added
  • Tests & Build

    • Functionality added by the pull request is covered by tests
    • mvn clean verify has been executed successfully locally or a Travis build has passed

@StephanEwen
Copy link
Contributor

Good idea to upgrade the scala plugin. But with this change, it does not define a version at all.
I think it would need to be added to the "plugin management" section.

@zentol
Copy link
Contributor

zentol commented Jan 17, 2017

@StephanEwen There already is an entry for scala-maven-plugin in the plugin management section.

@StephanEwen
Copy link
Contributor

Okay, good.
Then I think this is probably good to merge.

@rmetzger Any reservations that the upgrade to the Apache Parent POM v18 has implications on release scripts, etc?

@rmetzger
Copy link
Contributor

I think its fine (as long as we are not merging it to the 1.2 release branch)

@shijinkui
Copy link
Contributor Author

@rmetzger Any reservations that the upgrade to the Apache Parent POM v18 has implications on release scripts, etc?

@StephanEwen There's no effect to the create_release_files.sh in my opinion.
from v14 to v18, there are some plugins' version upgrade.

<plugin>
<groupId>net.alchim31.maven</groupId>
<artifactId>scala-maven-plugin</artifactId>
<version>3.1.4</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you an not remove the version here. Where does the generated project get the plugin version from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have fix it. Thanks for review:)

@shijinkui shijinkui force-pushed the FLINK-5519_scala-maven-plugin branch from d583bf6 to 2646dcf Compare January 18, 2017 08:27
StephanEwen pushed a commit to StephanEwen/flink that referenced this pull request Jan 18, 2017
@StephanEwen
Copy link
Contributor

Looks good, thanks. merging this...

StephanEwen pushed a commit to StephanEwen/flink that referenced this pull request Jan 18, 2017
StephanEwen pushed a commit to StephanEwen/flink that referenced this pull request Jan 19, 2017
@asfgit asfgit closed this in a18657d Jan 19, 2017
joseprupi pushed a commit to joseprupi/flink that referenced this pull request Feb 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants