Skip to content

Conversation

shijinkui
Copy link
Contributor

QueryStringDecoder and HttpPostRequestDecoder use UTF-8 defined in flink.
Response set content-encoding header with utf-8

  • General

    • The pull request references the related JIRA issue ("[FLINK-5705] webmonitor request/response use UTF-8 explicitly")
    • The pull request addresses only one issue
    • Each commit in the PR has a meaningful commit message (including the JIRA id)
  • Documentation

    • Documentation has been added for new functionality
    • Old documentation affected by the pull request has been updated
    • JavaDoc for public methods has been added
  • Tests & Build

    • Functionality added by the pull request is covered by tests
    • mvn clean verify has been executed successfully locally or a Travis build has passed

@shijinkui shijinkui changed the title [FLINK-5705] [WebMonitor] webmonitor request/response use UTF-8 expli… [FLINK-5705] [WebMonitor] request/response use UTF-8 explicitly Feb 13, 2017
@StephanEwen
Copy link
Contributor

The fix looks good, thanks!
Merging this...

StephanEwen pushed a commit to StephanEwen/flink that referenced this pull request Feb 16, 2017
StephanEwen pushed a commit to StephanEwen/flink that referenced this pull request Feb 16, 2017
StephanEwen pushed a commit to StephanEwen/flink that referenced this pull request Feb 16, 2017
StephanEwen pushed a commit to StephanEwen/flink that referenced this pull request Feb 16, 2017
@asfgit asfgit closed this in f245143 Feb 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants