[FLINK-6286] [script] Fix the hbase command not found error

[lingjinjiang]

When using flink with the HBASE_CONF_DIR env variable and don't install hbase, then will get the "hbase command not found" error.

https://issues.apache.org/jira/browse/FLINK-6286

[greghogan]

Hi @lingjinjiang, I am not familiar with configuring HBase for Flink and we don't seem to have documentation on this. What does it mean to have HBASE_CONF_DIR set but not have hbase available?

[lingjinjiang]

Hi @greghogan , In the config.sh, there is a if statement identifies whether HBASE_CONF_DIR is setted.
If the HBASE_CONF_DIR is setted, then will use the "hbase classpath" command to add the hbase's classpath to flink's classpath.
But it does not check whether the "hbase" command is existed before using it.
Then in the host where I'm using flink, another application need this env variable and there is no "hbase" command, then the error happen.

[greghogan]

Would it be better to replace the outer if-statement (line 312) with the test for the presence of hbase? And to log a message that HBASE_CONF_DIR is defined but hbase was not found so no HBase jars are included on the classpath?

[lingjinjiang]

@greghogan , I add some comments and log the message about hbase command not found.

[greghogan]

I'm not sure this is the best way to integrate the HBase classpath but +1 to fixing the error with a detailed log message.

[greghogan]

Perhaps more like "HBASE_CONF_DIR="${HBASE_CONF_DIR}" is set but 'hbase' command was not found in "${HBASE_PATH}" so classpath could not be updated."? I assumed HBASE_PATH="${HBASE_HOME}/bin:$PATH" as a local variable.

[lingjinjiang]

@greghogan, thanks for your suggestion. I have changed the log message.

[greghogan]

@lingjinjiang thanks for your contribution! Merging ...

[lingjinjiang]

@greghogan thanks for your review. I have another question, how can I assign the issue to myself ?

[greghogan]

@fhueske can grant you Jira permissions.

[zentol]

@lingjinjiang You are now the proud owner of contributor permissions and can assign issues to yourself.

[lingjinjiang]

@greghogan @zentol thanks. Can this pull request be merged or closed now ?