[FLINK-6461] Replace usages of deprecated web port key #3951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnowojski
approved these changes
Jun 19, 2017
| */ | ||
| val webMonitorPort : Int = flinkConfiguration.getInteger( | ||
| ConfigConstants.JOB_MANAGER_WEB_PORT_KEY, -1) | ||
| JobManagerOptions.WEB_PORT.key(), -1) |
There was a problem hiding this comment.
I am not sure, but why don't you use flinkConfiguration.getInteger(JobManagerOptions.WEB_PORT)? It would have different semantics (it would return 8081 instead of -1 in case of missing value).
There was a problem hiding this comment.
I thought about doing that, but decided against it to preserve existing behavior. If no port is configured at all, with the current code, a random port will be used. Someone out there may be relying on this (although they should just explicitly set it to 0)
|
merging. |
zentol
added a commit
to zentol/flink
that referenced
this pull request
Jun 26, 2017
zentol
added a commit
to zentol/flink
that referenced
this pull request
Jun 27, 2017
zentol
added a commit
to zentol/flink
that referenced
this pull request
Jun 27, 2017
zentol
added a commit
to zentol/flink
that referenced
this pull request
Jun 28, 2017
zentol
added a commit
to zentol/flink
that referenced
this pull request
Jun 28, 2017
zentol
added a commit
to zentol/flink
that referenced
this pull request
Jun 28, 2017
zentol
added a commit
to zentol/flink
that referenced
this pull request
Jun 29, 2017
zentol
added a commit
to zentol/flink
that referenced
this pull request
Jun 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to c102547; I missed some usages of
ConfigConstants#JOB_MANAGER_WEB_PORT_KEY.