[FLINK-7140][blob] add an additional random component into the BlobKey #4359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greghogan
reviewed
Jul 19, 2017
| protected final long lowerPart; | ||
|
|
||
| /** The memoized value returned by toString() */ | ||
| /** The memorized value returned by toString() */ |
There was a problem hiding this comment.
Oh, hey, that was me. I was just thinking about this the other day and how the JobManager used to bottleneck for large jobs when logging and converting these AbstractID to string. Anyway, this original should be the correct spelling: https://en.wikipedia.org/wiki/Memoization
There was a problem hiding this comment.
you're right...learned something today :)
NicoK
force-pushed
the
flink-6916-7140
branch
5 times, most recently
from
fbbdea8 to
0a28e51
Compare
NicoK
force-pushed
the
flink-6916-7140
branch
7 times, most recently
from
6c70f46 to
114ce68
Compare
|
rebased onto the latest #4358 |
This should guard us from uploading (and deleting) the same file more than once and also from hash collisions.
tillrohrmann
approved these changes
Oct 13, 2017
There was a problem hiding this comment.
Changes look good to me. Thanks for your contribution @NicoK. Will rebase it and once Travis passes, I'll merge it.
tillrohrmann
pushed a commit
to tillrohrmann/flink
that referenced
this pull request
Oct 13, 2017
This should guard us from uploading (and deleting) the same file more than once and also from hash collisions. This closes apache#4359.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should guard us from uploading (and deleting) the same file more than once and also from hash collisions.
This PR is based upon #4358 in a series to implement FLINK-6916.
General
Documentation
Tests & Build
mvn clean verifyhas been executed successfully locally or a Travis build has passed