Skip to content

Conversation

FangYongs
Copy link
Contributor

What is the purpose of the change

Shade jackson dependency in flink-avro to avoid incompatible versions

Brief change log

  • Shade jackson in pom.xml of flink-avro project

Verifying this change

(Please pick either of the following options)

No test case

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Copy link
Contributor

@zentol zentol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had one comment, otherwise +1 to merge.

<relocations>
<relocation>
<pattern>org.codehaus.jackson</pattern>
<shadedPattern>org.apache.flink.shaded.avro.org.codehouse.jackson</shadedPattern>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please switch the pattern to ... avro.shaded.... . I would like to reserver the org.apache.flink.shaded namespaces for dependencies from flink-shaded.

@FangYongs
Copy link
Contributor Author

@zentol Thank you for your review, I have rename the pattern, thanks

@StephanEwen
Copy link
Contributor

Merging this...

@zentol
Copy link
Contributor

zentol commented Nov 6, 2017

@zjureel The PR has been merged, could you close the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants