Skip to content

Conversation

vetriselvan1187
Copy link

@vetriselvan1187 vetriselvan1187 commented Nov 6, 2017

No description provided.

@vetriselvan1187 vetriselvan1187 changed the title private scope is changed to public to resolve access exception [FLINK-7998] private scope is changed to public to resolve access exception Nov 7, 2017
@greghogan
Copy link
Contributor

Looks good but I have not tested. Can we also fix the parameter swap referenced in the JIRA?

@naeioi
Copy link

naeioi commented Nov 8, 2017

Also can you replace params.get("order") with params.get("orders") in TPCHQuery3.scala for consistency with java and the input hint?

Vetrisevan1187 added 4 commits November 8, 2017 15:23
…orders") in TPCHQuery3.scala and

 fixed the wrong assigned parameter reference in TPCHQuery3.java. input hint is modified
…orders") in TPCHQuery3.scala and

 fixed the wrong assigned parameter reference in TPCHQuery3.java. input hint is modified.
@vetriselvan1187
Copy link
Author

@greghogan @naeioi have done some changes in both TPCHQuery3.scala and TCPCHQuery3.java

@zentol
Copy link
Contributor

zentol commented Nov 14, 2017

Thank you for fixing this, merging.

asfgit pushed a commit that referenced this pull request Nov 14, 2017
@asfgit asfgit closed this in 408e186 Nov 14, 2017
glaksh100 pushed a commit to lyft/flink that referenced this pull request Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants