-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-8549] [config] Move TimerServiceOptions into TaskManagerOptions #5402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable.
Note: The generator can pick up ConfigOptions in any module so long as they are public (and the generator is configured to do so). This was recently implemented to support python/mesos/netty options that aren't in flink-core.
*/ | ||
public static final ConfigOption<Long> TASK_CANCELLATION_TIMEOUT_TIMERS = ConfigOptions | ||
.key("task.cancellation.timeout.timers") | ||
.defaultValue(7500L); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add deprecated key? (I'm not quite sure whether the previous option was part of a release)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point - I just checked, it was in fact already part of 1.4 (I had falsely in my mind that it was new in 1.5)
Thanks for the heads up - nice to know that the generator also supports different projects now. I am still leaning towards making this change, because all other shutdown options are already in the |
f5045b2
to
72e093b
Compare
The
TimerServiceOptions
are in the wrong place, which prohibits generation of config docs. It also cause over-fragmentation of the options in the code base.This PR moves the one option from that class to the
TaskManagerOptions
, as it relates to task execution. Other shutdown related options are in there already.