Skip to content

Conversation

walterddr
Copy link
Contributor

@walterddr walterddr commented May 22, 2018

What is the purpose of the change

Adding end to end test for REST APIs for FLIP-6 generated endpoints.

Brief change log

  • Adding in flink-rest-api-test module and test_rest_api.sh for end-to-end testing
  • Adding in payload YAML file for endpoints used by REST APIs if any POST/PATCH endpoint requires a payload.
  • Adding a validation sequence before testing REST API modules in order to extract all path / query parameters for REST API endpoints.

Verifying this change

This test is run successfully against all REST API in DispatcherRestEndpoint.

This test will automatically pickup new endpoints for testing as long as support is added to DispatcherRestEndpoint.

If new endpoint requires additional path / payload / query parameter, test will be skipped instead of failing for the new endpoints.

Does this pull request potentially affect one of the following parts:

No

Documentation

No documentations for this test.

Rong Rong and others added 5 commits May 27, 2018 16:45
@tillrohrmann
Copy link
Contributor

Thanks for creating this PR @walterddr and sorry that it did not get the attention it deserved.

Rethinking the issue a bit I am now a bit unsure whether we should add the REST tests as e2e tests. Given the problems we had in the past with the bash based e2e tests, it might be more maintainable to write these tests as integration test cases. Hence, I would propose to close this PR. Sorry that I did not mention this consideration earlier.

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 18, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@walterddr
Copy link
Contributor Author

@tillrohrmann I almost forgot about this :-) yes, totally agree. I think it makes sense to do so in the ITCase path. (I had once try to rebase this PR onto a later release and there were a lot of problems)

@walterddr walterddr closed this Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants