[FLINK-9804][state] KeyedStateBackend.getKeys() does not work on RocksDB MapState #6306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @aljoscha |
aljoscha
approved these changes
Jul 12, 2018
There was a problem hiding this comment.
This looks very good! I had one code comment but you can ignore that one.
Possibly @StefanRRichter also wants to have a look but I think you can merge. We should fix this both for 1.5.x and 1.6.0.
| this.keyGroupPrefixBytes = Preconditions.checkNotNull(keyGroupPrefixBytes); | ||
| this.namespaceBytes = Preconditions.checkNotNull(namespaceBytes); | ||
| this.nextKey = null; | ||
| this.preKey = null; |
There was a problem hiding this comment.
Maybe call this previousKey, just to be more clear.
|
@aljoscha Thanks for your quick review, will address your comments while merging. |
asfgit
pushed a commit
that referenced
this pull request
Jul 12, 2018
sampathBhat
pushed a commit
to sampathBhat/flink
that referenced
this pull request
Jul 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR fixes the bug that the KeyedStateBackend.getKeys() does not work on RocksDB MapState.
Brief change log
RocksDBKeyedStateBackend#RocksIteratorForKeysWrapper()to let it support get keys for RocksDB MapState.Verifying this change
StateBackendTestBase#testMapStateGetKeys()to guard the changesDoes this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation