[FLINK-9811][rest] Add test for jar handler interactions #6311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zentol
commented
Jul 13, 2018
| runJar(runHandler, storedJarName, restfulGateway); | ||
| Assert.fail("We assume the actual job submission to fail."); | ||
| } catch (Exception e) { | ||
| final Optional<ConnectException> expected = ExceptionUtils.findThrowable(e, ConnectException.class); |
There was a problem hiding this comment.
we can make this part a lot nicer by starting a BlobServer´ like we do in the JobSubmitHandlerTestand setting asubmitFunctionon theTestingDispatcherGateway`.
Will add this later.
Adjusted to work like the JobSubmitHandler.
tillrohrmann
approved these changes
Jul 18, 2018
There was a problem hiding this comment.
Thanks for adding this test @zentol. LGTM. Addressing my comment while merging this PR.
| /** | ||
| * Tests the entire lifecycle of a jar submission. | ||
| */ | ||
| public class JarSubmissionITCase { |
There was a problem hiding this comment.
Should extend TestLogger.
asfgit
pushed a commit
that referenced
this pull request
Jul 18, 2018
zentol
added a commit
to zentol/flink
that referenced
this pull request
Jul 19, 2018
asfgit
pushed a commit
that referenced
this pull request
Jul 19, 2018
sampathBhat
pushed a commit
to sampathBhat/flink
that referenced
this pull request
Jul 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR adds an ITCase for the interactions between jar handlers.
The test goes through the following life-cycle:
Brief change log
sync dispatcher hostname retrieval in
JarRunHandlerwithJobSubmitHandleradd
TestProgramclass andmaven-jar-pluginexecution to create a test jar for the testmodify visibility of various
*MessageParameterclasses to make them usable for java codeadd
JarSubmissionITCaseVerifying this change
Manually verified. The assertions made are fairly straight-forward.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation