[FLINK-10263] [sql-client] Fix classloader issues in SQL Client #6725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes classloading issues when using a UDF with constant parameters. Every optimization might need to compile code (i.e. for constant folding), thus, needs access to the user-code classloader.
dawidwys
reviewed
Sep 21, 2018
| Thread.currentThread().setContextClassLoader(classLoader); | ||
| R returnValue; | ||
| try { | ||
| returnValue = supplier.get(); |
There was a problem hiding this comment.
Can't we just return it here?
|
Thank you @dawidwys. I simplified the code there. |
asfgit
pushed a commit
that referenced
this pull request
Sep 26, 2018
Fixes classloading issues when using a UDF with constant parameters. Every optimization might need to compile code (i.e. for constant folding), thus, needs access to the user-code classloader. This closes #6725.
Clarkkkkk
pushed a commit
to Clarkkkkk/flink
that referenced
this pull request
Mar 7, 2019
Fixes classloading issues when using a UDF with constant parameters. Every optimization might need to compile code (i.e. for constant folding), thus, needs access to the user-code classloader. This closes apache#6725. (cherry picked from commit 116347e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fixes classloading issues when using a UDF with constant parameters. Every
optimization might need to compile code (i.e. for constant folding), thus,
needs access to the user-code classloader.
Brief change log
Set SQL Client's execution context class loader as thread classloader and use it for constant folding.
Verifying this change
End-to-end test has been extended.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation