[FLINK-2342] [ml] Add new fit operation and more tests for StandardScaler #899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @thvasilo for the PR. |
|
Looks good to merge. If there is no other opinions in 2-3 days, I'll merge this to master. |
|
+1 for merging |
|
Merging this... |
|
Changes Unknown when pulling aa18b3d on thvasilo:scaler-extra-tests into ** on apache:master**. |
pnowojski
pushed a commit
that referenced
this pull request
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StandardScaler currently has a transform operation for types (Vector, Double), but no corresponding fit operation.
The test cases also do not cover all the possible types that we can call fit and transform on.
This PR addresses this, and removes some unused code.