@CompileStatic causes StackOverflowError on Controller

[jdaugherty]

Issue description

When running compileGroovy on example project https://github.com/jdaugherty/grails-issue-stackoverflow-on-compile

The following error occurs:

    FAILURE: Build failed with an exception.
    
    * What went wrong:
      Execution failed for task ':compileGroovy'.
    > java.lang.StackOverflowError (no error message)

[paulk-asert]

Here is the stack trace:

Caused by: java.lang.StackOverflowError
        at org.codehaus.groovy.ast.GenericsType.<init>(GenericsType.java:53)
        at org.codehaus.groovy.ast.GenericsType.<init>(GenericsType.java:57)
        at org.codehaus.groovy.ast.tools.GenericsUtils.correctToGenericsSpecRecurse(GenericsUtils.java:435)
        at org.codehaus.groovy.ast.tools.GenericsUtils.correctToGenericsSpecRecurse(GenericsUtils.java:371)
        at org.codehaus.groovy.ast.tools.GenericsUtils.extractSuperClassGenerics(GenericsUtils.java:561)
        at org.codehaus.groovy.ast.tools.GenericsUtils.parameterizeType(GenericsUtils.java:294)
        at org.codehaus.groovy.ast.tools.GeneralUtils.addAllInterfaces(GeneralUtils.java:482)
        at org.codehaus.groovy.ast.tools.GeneralUtils.addAllInterfaces(GeneralUtils.java:484)
        at org.codehaus.groovy.ast.tools.GeneralUtils.getInterfacesAndSuperInterfaces(GeneralUtils.java:495)
        at org.codehaus.groovy.ast.tools.WideningCategories.lowestUpperBound(WideningCategories.java:422)
        at org.codehaus.groovy.ast.tools.WideningCategories.lowestUpperBound(WideningCategories.java:210)
        at org.codehaus.groovy.ast.tools.WideningCategories.parameterizeLowestUpperBound(WideningCategories.java:276)
        at org.codehaus.groovy.ast.tools.WideningCategories.lowestUpperBound(WideningCategories.java:232)
        at org.codehaus.groovy.ast.tools.WideningCategories.parameterizeLowestUpperBound(WideningCategories.java:276)
        at org.codehaus.groovy.ast.tools.WideningCategories.lowestUpperBound(WideningCategories.java:232)
        at org.codehaus.groovy.ast.tools.WideningCategories.parameterizeLowestUpperBound(WideningCategories.java:276)
        at org.codehaus.groovy.ast.tools.WideningCategories.lowestUpperBound(WideningCategories.java:232)
        at org.codehaus.groovy.ast.tools.WideningCategories.parameterizeLowestUpperBound(WideningCategories.java:276)
        at org.codehaus.groovy.ast.tools.WideningCategories.lowestUpperBound(WideningCategories.java:232)
        at org.codehaus.groovy.ast.tools.WideningCategories.parameterizeLowestUpperBound(WideningCategories.java:276)
        at org.codehaus.groovy.ast.tools.WideningCategories.lowestUpperBound(WideningCategories.java:232)
        ...

[paulk-asert]

When I debug the local variables at that point I see:

icn = io.fabric8.kubernetes.api.builder.VisitableBuilder<io.fabric8.kubernetes.api.model.batch.v1.Job, io.fabric8.kubernetes.api.model.batch.v1.JobBuilder>
  -> io.fabric8.kubernetes.api.builder.VisitableBuilder<T, V extends io.fabric8.kubernetes.api.builder.VisitableBuilder<T, V>>
i = 0
n = 1
a = io.fabric8.kubernetes.api.model.batch.v1.JobBuilder
b = io.fabric8.kubernetes.api.model.PodBuilder
...
icn = io.fabric8.kubernetes.api.builder.Editable<io.fabric8.kubernetes.api.model.batch.v1.JobBuilder>
  -> io.fabric8.kubernetes.api.builder.Editable<T>
i = 0
n = 3
a = io.fabric8.kubernetes.api.model.batch.v1.Job
b = io.fabric8.kubernetes.api.model.Pod
...

[matrei]

It fails with the same exception if you change from @GrailsCompileStatic to @CompileStatic.
Looks like a Groovy 4 issue then?

[jdaugherty]

So the classes being validated are java classes from a third party library, does that mean groovy is trying to apply validations here that java allows?

[paulk-asert]

It is probably a Groovy problem with self-recursive generic definitions. We have fixed most cases of that - but this might be a more elaborate case we still need to cover. There is also a small chance that it could also be an AST transform not calling getPlainNodeReference when it needs to - which might cause recursion where it shouldn't be needed. Perhaps Groovy should guard against that case anyway - but the AST transform (if indeed that is what is happening) should also get a fix.

I'll try to replicate outside Grails.