Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDFS-15350. Set dfs.client.failover.random.order to true as default. #2008

Merged
merged 2 commits into from
May 12, 2020
Merged

HDFS-15350. Set dfs.client.failover.random.order to true as default. #2008

merged 2 commits into from
May 12, 2020

Conversation

tasanuma
Copy link
Member

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 27s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 🆗 mvndep 0m 51s Maven dependency ordering for branch
+1 💚 mvninstall 22m 9s trunk passed
+1 💚 compile 3m 49s trunk passed
+1 💚 checkstyle 0m 58s trunk passed
+1 💚 mvnsite 2m 7s trunk passed
+1 💚 shadedclient 18m 16s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 1m 12s trunk passed
+0 🆗 spotbugs 3m 41s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 6m 6s trunk passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 25s Maven dependency ordering for patch
+1 💚 mvninstall 2m 19s the patch passed
+1 💚 compile 4m 15s the patch passed
+1 💚 javac 4m 15s the patch passed
+1 💚 checkstyle 1m 5s the patch passed
+1 💚 mvnsite 2m 14s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 2s The patch has no ill-formed XML file.
+1 💚 shadedclient 16m 5s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 1m 15s the patch passed
+1 💚 findbugs 6m 43s the patch passed
_ Other Tests _
+1 💚 unit 2m 19s hadoop-hdfs-client in the patch passed.
-1 ❌ unit 98m 27s hadoop-hdfs in the patch passed.
+1 💚 asflicense 0m 36s The patch does not generate ASF License warnings.
192m 15s
Reason Tests
Failed junit tests hadoop.hdfs.server.datanode.TestNNHandlesBlockReportPerStorage
hadoop.hdfs.server.namenode.TestNestedEncryptionZones
hadoop.hdfs.server.namenode.ha.TestObserverReadProxyProvider
hadoop.hdfs.TestDecommissionWithStripedBackoffMonitor
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2008/1/artifact/out/Dockerfile
GITHUB PR #2008
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
uname Linux bf0f9b5d6e42 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 328eae9
Default Java Private Build-1.8.0_252-8u252-b09-1~18.04-b09
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-2008/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-2008/1/testReport/
Max. process+thread count 3524 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-2008/1/console
versions git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

kihwal
kihwal approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@kihwal kihwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@tasanuma
Copy link
Member Author

Thanks for your review, @kihwal.

Some failed tests seem to be related to this change. They may assume that dfs.client.failover.random.order=false. I will check them.

@tasanuma
Copy link
Member Author

Updated PR to fix the failed test.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 22m 22s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 0m 56s Maven dependency ordering for branch
+1 💚 mvninstall 19m 6s trunk passed
+1 💚 compile 3m 33s trunk passed
+1 💚 checkstyle 0m 56s trunk passed
+1 💚 mvnsite 2m 7s trunk passed
+1 💚 shadedclient 17m 3s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 1m 20s trunk passed
+0 🆗 spotbugs 2m 54s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 5m 8s trunk passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 26s Maven dependency ordering for patch
+1 💚 mvninstall 1m 55s the patch passed
+1 💚 compile 3m 24s the patch passed
+1 💚 javac 3m 24s the patch passed
+1 💚 checkstyle 0m 48s the patch passed
+1 💚 mvnsite 1m 58s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 2s The patch has no ill-formed XML file.
+1 💚 shadedclient 13m 40s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 1m 15s the patch passed
+1 💚 findbugs 5m 11s the patch passed
_ Other Tests _
+1 💚 unit 2m 4s hadoop-hdfs-client in the patch passed.
-1 ❌ unit 105m 6s hadoop-hdfs in the patch passed.
+1 💚 asflicense 0m 42s The patch does not generate ASF License warnings.
209m 41s
Reason Tests
Failed junit tests hadoop.hdfs.server.namenode.TestMetaSave
hadoop.hdfs.TestErasureCodingPoliciesWithRandomECPolicy
hadoop.hdfs.server.balancer.TestBalancer
hadoop.hdfs.TestRollingUpgrade
hadoop.hdfs.server.namenode.TestNamenodeRetryCache
hadoop.hdfs.TestFileChecksumCompositeCrc
hadoop.hdfs.TestDFSStripedOutputStreamWithFailureWithRandomECPolicy
hadoop.hdfs.TestMaintenanceState
hadoop.hdfs.TestErasureCodingExerciseAPIs
hadoop.hdfs.server.namenode.TestBlockPlacementPolicyRackFaultTolerant
hadoop.hdfs.TestDFSStripedOutputStreamWithRandomECPolicy
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2008/2/artifact/out/Dockerfile
GITHUB PR #2008
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
uname Linux 495674ca92a2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / bd342be
Default Java Private Build-1.8.0_252-8u252-b09-1~18.04-b09
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-2008/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-2008/2/testReport/
Max. process+thread count 3647 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-2008/2/console
versions git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

kihwal
kihwal approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@kihwal kihwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kihwal kihwal merged commit 928b81a into apache:trunk May 12, 2020
@tasanuma
Copy link
Member Author

Thanks for reviewing and merging it, @kihwal.

@tasanuma tasanuma deleted the HDFS-15350 branch May 12, 2020 17:22
jojochuang pushed a commit to jojochuang/hadoop that referenced this pull request May 23, 2023
@tasanuma
HDFS-15350. Set dfs.client.failover.random.order to true as default. (a…
192375c 
…pache#2008)

(cherry picked from commit 928b81a)

 Conflicts:
	hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/HdfsClientConfigKeys.java
	hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestObserverReadProxyProvider.java

Change-Id: I20ea7b8e370d0b90b9b5c13cb1886c495e909c3f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kihwal kihwal kihwal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tasanuma @hadoop-yetus @kihwal