Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-17402. Add GCS config to the core-site (#2638) #3180

Merged

Conversation

ravwojdyla
Copy link
Contributor

Follow up from: #2638 (comment)

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 7m 31s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ branch-3.3 Compile Tests _
+1 💚 mvninstall 29m 57s branch-3.3 passed
+1 💚 compile 17m 22s branch-3.3 passed
+1 💚 checkstyle 0m 55s branch-3.3 passed
+1 💚 mvnsite 1m 37s branch-3.3 passed
+1 💚 javadoc 1m 41s branch-3.3 passed
+1 💚 spotbugs 2m 22s branch-3.3 passed
+1 💚 shadedclient 18m 5s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 1m 2s the patch passed
+1 💚 compile 18m 3s the patch passed
+1 💚 javac 18m 3s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 54s the patch passed
+1 💚 mvnsite 1m 35s the patch passed
+1 💚 xml 0m 2s The patch has no ill-formed XML file.
+1 💚 javadoc 1m 41s the patch passed
+1 💚 spotbugs 2m 32s the patch passed
+1 💚 shadedclient 18m 3s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 16m 45s hadoop-common in the patch passed.
+1 💚 asflicense 0m 58s The patch does not generate ASF License warnings.
140m 26s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3180/1/artifact/out/Dockerfile
GITHUB PR #3180
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml spotbugs checkstyle
uname Linux 08617521936b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.3 / 091a7ba
Default Java Private Build-1.8.0_292-8u292-b10-0ubuntu1~18.04-b10
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3180/1/testReport/
Max. process+thread count 3158 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3180/1/console
versions git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@steveloughran steveloughran merged commit e3fb63f into apache:branch-3.3 Jul 7, 2021
@steveloughran
Copy link
Contributor

thanks, all merged in, JIRA closed, you get the credit there too.

Now, as you are looking at GCS, fancy looking at #2971 which is going to be a high performance yet correct committer for ABFS and GCS. If you are writing data to GCS right now through FileOutputCommitter, neither algorithm is safe....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants