HDFS-13522: IPC changes to support observer reads through routers. #4311

simbadzina · 2022-05-16T02:26:48Z

Description of PR

IPC changes so that clients send their txn number to routers and in turn routers will forward this to the namenodes. The code to direct routers to the observer namenodes will be in a follow up PR.

How was this patch tested?

Ran unit tests in module in Intellij

For code changes:

[ x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?

hadoop-yetus · 2022-05-16T10:51:26Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 36s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 12 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 49s		Maven dependency ordering for branch
+1 💚	mvninstall	25m 4s		trunk passed
+1 💚	compile	23m 8s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	20m 33s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	4m 22s		trunk passed
+1 💚	mvnsite	7m 40s		trunk passed
-1 ❌	javadoc	1m 51s	/branch-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt	hadoop-common in trunk failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.
+1 💚	javadoc	7m 48s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	12m 21s		trunk passed
+1 💚	shadedclient	23m 34s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 29s		Maven dependency ordering for patch
-1 ❌	mvninstall	0m 40s	/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-rbf.txt	hadoop-hdfs-rbf in the patch failed.
-1 ❌	compile	13m 44s	/patch-compile-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt	root in the patch failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.
-1 ❌	javac	13m 44s	/patch-compile-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt	root in the patch failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.
-1 ❌	compile	11m 53s	/patch-compile-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt	root in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.
-1 ❌	javac	11m 53s	/patch-compile-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt	root in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	3m 42s	/results-checkstyle-root.txt	root: The patch generated 2 new + 340 unchanged - 1 fixed = 342 total (was 341)
-1 ❌	mvnsite	0m 54s	/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs-rbf.txt	hadoop-hdfs-rbf in the patch failed.
+1 💚	xml	0m 3s		The patch has no ill-formed XML file.
-1 ❌	javadoc	1m 8s	/patch-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt	hadoop-common in the patch failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.
+1 💚	javadoc	5m 28s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
-1 ❌	spotbugs	0m 53s	/patch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-rbf.txt	hadoop-hdfs-rbf in the patch failed.
+1 💚	shadedclient	22m 39s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	17m 53s		hadoop-common in the patch passed.
+1 💚	unit	2m 38s		hadoop-hdfs-client in the patch passed.
+1 💚	unit	250m 44s		hadoop-hdfs in the patch passed.
-1 ❌	unit	1m 15s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt	hadoop-hdfs-rbf in the patch failed.
+1 💚	asflicense	1m 18s		The patch does not generate ASF License warnings.
		502m 44s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/1/artifact/out/Dockerfile
GITHUB PR	#4311
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell xml
uname	Linux 6bcb704d3094 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 4d719a20b5800ee95458be76182e642e72ef387d
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/1/testReport/
Max. process+thread count	3601 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-05-17T05:11:30Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 41s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	15m 53s		Maven dependency ordering for branch
+1 💚	mvninstall	26m 51s		trunk passed
+1 💚	compile	25m 13s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	21m 12s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	4m 25s		trunk passed
+1 💚	mvnsite	6m 46s		trunk passed
-1 ❌	javadoc	1m 32s	/branch-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt	hadoop-common in trunk failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.
+1 💚	javadoc	7m 5s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	12m 43s		trunk passed
+1 💚	shadedclient	23m 22s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 29s		Maven dependency ordering for patch
+1 💚	mvninstall	4m 14s		the patch passed
+1 💚	compile	24m 36s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	24m 36s		the patch passed
+1 💚	compile	22m 17s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	22m 17s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	4m 6s	/results-checkstyle-root.txt	root: The patch generated 2 new + 199 unchanged - 1 fixed = 201 total (was 200)
+1 💚	mvnsite	6m 57s		the patch passed
+1 💚	xml	0m 1s		The patch has no ill-formed XML file.
-1 ❌	javadoc	1m 33s	/patch-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt	hadoop-common in the patch failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.
+1 💚	javadoc	7m 1s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	12m 31s		the patch passed
+1 💚	shadedclient	22m 50s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	18m 45s		hadoop-common in the patch passed.
+1 💚	unit	3m 11s		hadoop-hdfs-client in the patch passed.
+1 💚	unit	266m 16s		hadoop-hdfs in the patch passed.
+1 💚	unit	24m 56s		hadoop-hdfs-rbf in the patch passed.
+1 💚	asflicense	1m 45s		The patch does not generate ASF License warnings.
		579m 40s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/2/artifact/out/Dockerfile
GITHUB PR	#4311
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell xml
uname	Linux e0dcb1f2bee6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 2b51acbedc942e184b4df1599b41010d32a4f8f6
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/2/testReport/
Max. process+thread count	3124 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-05-17T15:01:14Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 36s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 46s		Maven dependency ordering for branch
+1 💚	mvninstall	24m 56s		trunk passed
+1 💚	compile	23m 6s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	20m 35s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	4m 22s		trunk passed
+1 💚	mvnsite	7m 35s		trunk passed
-1 ❌	javadoc	1m 50s	/branch-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt	hadoop-common in trunk failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.
+1 💚	javadoc	7m 44s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	12m 21s		trunk passed
+1 💚	shadedclient	22m 33s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 31s		Maven dependency ordering for patch
+1 💚	mvninstall	4m 8s		the patch passed
+1 💚	compile	22m 32s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	22m 32s		the patch passed
+1 💚	compile	21m 45s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	21m 45s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	4m 42s	/results-checkstyle-root.txt	root: The patch generated 2 new + 199 unchanged - 1 fixed = 201 total (was 200)
+1 💚	mvnsite	7m 24s		the patch passed
+1 💚	xml	0m 2s		The patch has no ill-formed XML file.
-1 ❌	javadoc	1m 30s	/patch-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt	hadoop-common in the patch failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.
+1 💚	javadoc	7m 14s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	13m 3s		the patch passed
+1 💚	shadedclient	22m 43s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	18m 32s		hadoop-common in the patch passed.
+1 💚	unit	3m 15s		hadoop-hdfs-client in the patch passed.
+1 💚	unit	252m 28s		hadoop-hdfs in the patch passed.
+1 💚	unit	23m 33s		hadoop-hdfs-rbf in the patch passed.
+1 💚	asflicense	1m 46s		The patch does not generate ASF License warnings.
		559m 24s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/3/artifact/out/Dockerfile
GITHUB PR	#4311
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell xml
uname	Linux a8fa86f61127 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 4286ba88c975cf46ccb02504daa67464aed93ea4
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/3/testReport/
Max. process+thread count	3276 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

simbadzina · 2022-05-18T16:09:07Z

This pull request is followed up by #4127

hadoop-yetus · 2022-05-27T03:32:54Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 45s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 35s		Maven dependency ordering for branch
+1 💚	mvninstall	24m 24s		trunk passed
-1 ❌	compile	4m 5s	/branch-compile-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt	root in trunk failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.
-1 ❌	compile	3m 39s	/branch-compile-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt	root in trunk failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.
+1 💚	checkstyle	3m 53s		trunk passed
+1 💚	mvnsite	5m 46s		trunk passed
+1 💚	javadoc	4m 35s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	4m 53s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	10m 29s		trunk passed
+1 💚	shadedclient	20m 56s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 33s		Maven dependency ordering for patch
+1 💚	mvninstall	4m 9s		the patch passed
-1 ❌	compile	3m 48s	/patch-compile-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt	root in the patch failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.
-1 ❌	javac	3m 48s	/patch-compile-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt	root in the patch failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.
-1 ❌	compile	3m 21s	/patch-compile-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt	root in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.
-1 ❌	javac	3m 21s	/patch-compile-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt	root in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	3m 24s	/results-checkstyle-root.txt	root: The patch generated 2 new + 196 unchanged - 1 fixed = 198 total (was 197)
+1 💚	mvnsite	4m 50s		the patch passed
+1 💚	javadoc	3m 30s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	3m 58s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	10m 2s		the patch passed
+1 💚	shadedclient	20m 44s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	17m 46s		hadoop-common in the patch passed.
+1 💚	unit	2m 38s		hadoop-hdfs-client in the patch passed.
+1 💚	unit	250m 46s		hadoop-hdfs in the patch passed.
+1 💚	unit	22m 36s		hadoop-hdfs-rbf in the patch passed.
+1 💚	asflicense	1m 16s		The patch does not generate ASF License warnings.
		454m 35s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/4/artifact/out/Dockerfile
GITHUB PR	#4311
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname	Linux 5b9011855fce 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 4a3b31a8bbcd7caeb6661d8b6bec2d455e47470b
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/4/testReport/
Max. process+thread count	3567 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/4/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-06-01T03:33:00Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 38s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 27s		Maven dependency ordering for branch
+1 💚	mvninstall	24m 38s		trunk passed
-1 ❌	compile	4m 5s	/branch-compile-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt	root in trunk failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.
-1 ❌	compile	3m 38s	/branch-compile-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt	root in trunk failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.
+1 💚	checkstyle	3m 59s		trunk passed
+1 💚	mvnsite	5m 47s		trunk passed
+1 💚	javadoc	4m 30s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	4m 54s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	10m 30s		trunk passed
+1 💚	shadedclient	21m 10s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 30s		Maven dependency ordering for patch
+1 💚	mvninstall	4m 9s		the patch passed
-1 ❌	compile	3m 52s	/patch-compile-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt	root in the patch failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.
-1 ❌	javac	3m 52s	/patch-compile-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt	root in the patch failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.
-1 ❌	compile	3m 22s	/patch-compile-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt	root in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.
-1 ❌	javac	3m 22s	/patch-compile-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt	root in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	3m 33s	/results-checkstyle-root.txt	root: The patch generated 2 new + 196 unchanged - 1 fixed = 198 total (was 197)
+1 💚	mvnsite	4m 51s		the patch passed
+1 💚	javadoc	3m 33s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	4m 1s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	10m 8s		the patch passed
+1 💚	shadedclient	20m 45s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	17m 50s		hadoop-common in the patch passed.
+1 💚	unit	2m 38s		hadoop-hdfs-client in the patch passed.
-1 ❌	unit	248m 40s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	unit	23m 32s		hadoop-hdfs-rbf in the patch passed.
+1 💚	asflicense	1m 18s		The patch does not generate ASF License warnings.
		454m 0s

Reason	Tests
Failed junit tests	hadoop.hdfs.TestClientProtocolForPipelineRecovery
	hadoop.hdfs.TestRollingUpgrade

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/5/artifact/out/Dockerfile
GITHUB PR	#4311
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname	Linux a291c8a97c1d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 43853ef5f599af4fbe488b4392bdb8fb3e513f95
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/5/testReport/
Max. process+thread count	3152 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/5/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-06-04T06:06:17Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 36s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	15m 8s		Maven dependency ordering for branch
+1 💚	mvninstall	24m 46s		trunk passed
+1 💚	compile	22m 54s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	20m 25s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	4m 26s		trunk passed
+1 💚	mvnsite	7m 41s		trunk passed
+1 💚	javadoc	6m 28s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	6m 43s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	12m 20s		trunk passed
+1 💚	shadedclient	22m 30s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 30s		Maven dependency ordering for patch
+1 💚	mvninstall	4m 12s		the patch passed
+1 💚	compile	22m 7s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	22m 7s		the patch passed
+1 💚	compile	20m 26s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	20m 26s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	5m 26s	/results-checkstyle-root.txt	root: The patch generated 2 new + 196 unchanged - 1 fixed = 198 total (was 197)
+1 💚	mvnsite	7m 59s		the patch passed
+1 💚	javadoc	6m 20s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	6m 45s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	12m 58s		the patch passed
+1 💚	shadedclient	19m 45s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	18m 30s		hadoop-common in the patch passed.
+1 💚	unit	3m 14s		hadoop-hdfs-client in the patch passed.
+1 💚	unit	252m 50s		hadoop-hdfs in the patch passed.
+1 💚	unit	22m 46s		hadoop-hdfs-rbf in the patch passed.
+1 💚	asflicense	1m 57s		The patch does not generate ASF License warnings.
		555m 9s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/6/artifact/out/Dockerfile
GITHUB PR	#4311
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname	Linux 6c979e06d791 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 41312cb88c2f23e0620d9240e5d49bc0590be0b8
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/6/testReport/
Max. process+thread count	3586 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/6/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

melissayou

LGTM.

...p-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/ClientGSIContext.java

...s-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/NameNodeProxiesClient.java

...p-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/ClientGSIContext.java

...dfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/ConnectionManager.java

ZanderXu

@simbadzina This feature is very helpful. If you don't have time, I'd be happy to do something for you to push this feature forward.

hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java

...s-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/NameNodeProxiesClient.java

...dfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/ConnectionManager.java

...-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterStateIdContext.java

hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java

...s-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/NameNodeProxiesClient.java

...dfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/ConnectionManager.java

hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml

ZanderXu · 2022-06-15T03:49:44Z

@simbadzina @omalley @melissayou I create a draft PR, and have some different points, like:

Proxy always with AlignmentContext, like RouterGSIContext which contains a boolean flag, like enableObserverRead
Always update the lastSeenStateId from active
If enableObserverRead is false, updateRequestState will not set lastSeenStateId in RPCHeader
It's easily to dynamically reconfigure enableObserverRead.

I'm hope that we can continue push this Feature forward. Please help me review it.

@simbadzina If you want to continue work for this feature, feel free to take over it. Thanks~

hadoop-yetus · 2022-06-16T08:34:08Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 42s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 39s		Maven dependency ordering for branch
+1 💚	mvninstall	26m 42s		trunk passed
+1 💚	compile	26m 34s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	23m 28s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	4m 58s		trunk passed
+1 💚	mvnsite	7m 39s		trunk passed
-1 ❌	javadoc	1m 36s	/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt	hadoop-hdfs in trunk failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.
+1 💚	javadoc	6m 37s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	12m 53s		trunk passed
+1 💚	shadedclient	23m 4s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 33s		Maven dependency ordering for patch
+1 💚	mvninstall	4m 30s		the patch passed
+1 💚	compile	24m 50s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	24m 50s		the patch passed
+1 💚	compile	22m 57s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	22m 57s		the patch passed
-1 ❌	blanks	0m 1s	/blanks-eol.txt	The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-0 ⚠️	checkstyle	4m 18s	/results-checkstyle-root.txt	root: The patch generated 3 new + 198 unchanged - 1 fixed = 201 total (was 199)
+1 💚	mvnsite	7m 20s		the patch passed
-1 ❌	javadoc	1m 41s	/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt	hadoop-hdfs in the patch failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.
+1 💚	javadoc	6m 28s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	13m 28s		the patch passed
+1 💚	shadedclient	24m 42s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	19m 25s		hadoop-common in the patch passed.
+1 💚	unit	3m 9s		hadoop-hdfs-client in the patch passed.
+1 💚	unit	258m 53s		hadoop-hdfs in the patch passed.
-1 ❌	unit	23m 32s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt	hadoop-hdfs-rbf in the patch passed.
+1 💚	asflicense	2m 0s		The patch does not generate ASF License warnings.
		580m 49s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.federation.router.TestConnectionManager

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/7/artifact/out/Dockerfile
GITHUB PR	#4311
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname	Linux be4aec47dab0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / a02081acfc8cb79e7e3e61c45594b0a5bf034141
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/7/testReport/
Max. process+thread count	3152 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/7/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-06-17T01:05:58Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 37s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+0 🆗	xmllint	0m 1s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	44m 39s		Maven dependency ordering for branch
+1 💚	mvninstall	24m 44s		trunk passed
+1 💚	compile	22m 49s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	20m 27s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	4m 24s		trunk passed
+1 💚	mvnsite	7m 44s		trunk passed
-1 ❌	javadoc	1m 45s	/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt	hadoop-hdfs in trunk failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.
+1 💚	javadoc	6m 50s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	12m 22s		trunk passed
+1 💚	shadedclient	22m 27s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 34s		Maven dependency ordering for patch
+1 💚	mvninstall	4m 10s		the patch passed
+1 💚	compile	22m 3s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	22m 3s		the patch passed
+1 💚	compile	20m 26s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	20m 26s		the patch passed
-1 ❌	blanks	0m 0s	/blanks-eol.txt	The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-0 ⚠️	checkstyle	4m 13s	/results-checkstyle-root.txt	root: The patch generated 3 new + 198 unchanged - 1 fixed = 201 total (was 199)
+1 💚	mvnsite	7m 42s		the patch passed
-1 ❌	javadoc	1m 45s	/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt	hadoop-hdfs in the patch failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.
+1 💚	javadoc	6m 49s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	12m 54s		the patch passed
+1 💚	shadedclient	22m 52s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	18m 42s		hadoop-common in the patch passed.
+1 💚	unit	3m 14s		hadoop-hdfs-client in the patch passed.
-1 ❌	unit	256m 19s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	unit	23m 12s		hadoop-hdfs-rbf in the patch passed.
+1 💚	asflicense	2m 0s		The patch does not generate ASF License warnings.
		590m 36s

Reason	Tests
Failed junit tests	hadoop.cli.TestHDFSCLI

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/8/artifact/out/Dockerfile
GITHUB PR	#4311
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname	Linux 7200bc04ac4a 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 82a59d04438670a5135badf54be0cf49d0e3b338
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/8/testReport/
Max. process+thread count	3321 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/8/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-06-20T16:46:34Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 38s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 51s		Maven dependency ordering for branch
+1 💚	mvninstall	54m 43s		trunk passed
+1 💚	compile	22m 55s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	20m 36s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	4m 23s		trunk passed
+1 💚	mvnsite	7m 48s		trunk passed
+1 💚	javadoc	6m 18s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	6m 48s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	12m 22s		trunk passed
+1 💚	shadedclient	22m 30s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 30s		Maven dependency ordering for patch
+1 💚	mvninstall	4m 7s		the patch passed
+1 💚	compile	22m 4s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	22m 4s		the patch passed
+1 💚	compile	20m 23s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	20m 23s		the patch passed
-1 ❌	blanks	0m 0s	/blanks-eol.txt	The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-0 ⚠️	checkstyle	4m 21s	/results-checkstyle-root.txt	root: The patch generated 3 new + 198 unchanged - 1 fixed = 201 total (was 199)
+1 💚	mvnsite	7m 42s		the patch passed
+1 💚	javadoc	6m 22s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	6m 35s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	12m 59s		the patch passed
+1 💚	shadedclient	22m 58s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	18m 23s		hadoop-common in the patch passed.
+1 💚	unit	3m 18s		hadoop-hdfs-client in the patch passed.
-1 ❌	unit	243m 45s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	unit	25m 15s		hadoop-hdfs-rbf in the patch passed.
+1 💚	asflicense	1m 40s		The patch does not generate ASF License warnings.
		579m 42s

Reason	Tests
Failed junit tests	hadoop.cli.TestHDFSCLI
	hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/9/artifact/out/Dockerfile
GITHUB PR	#4311
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname	Linux 1693df608f95 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 38ee8b13c7e6cdfe04dac1de90e67d852df8140e
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/9/testReport/
Max. process+thread count	3465 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/9/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-06-22T04:08:11Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 37s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+0 🆗	xmllint	0m 1s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 40s		Maven dependency ordering for branch
+1 💚	mvninstall	25m 8s		trunk passed
+1 💚	compile	23m 12s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	20m 36s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	4m 21s		trunk passed
+1 💚	mvnsite	7m 41s		trunk passed
+1 💚	javadoc	6m 28s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	6m 50s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	12m 24s		trunk passed
+1 💚	shadedclient	22m 29s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 33s		Maven dependency ordering for patch
+1 💚	mvninstall	4m 11s		the patch passed
+1 💚	compile	22m 4s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	22m 4s		the patch passed
+1 💚	compile	20m 20s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	20m 20s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	4m 13s	/results-checkstyle-root.txt	root: The patch generated 2 new + 198 unchanged - 1 fixed = 200 total (was 199)
+1 💚	mvnsite	7m 45s		the patch passed
+1 💚	javadoc	6m 21s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	6m 50s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	12m 57s		the patch passed
+1 💚	shadedclient	22m 42s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	18m 30s		hadoop-common in the patch passed.
+1 💚	unit	3m 16s		hadoop-hdfs-client in the patch passed.
-1 ❌	unit	239m 55s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	unit	23m 0s		hadoop-hdfs-rbf in the patch passed.
+1 💚	asflicense	2m 0s		The patch does not generate ASF License warnings.
		544m 30s

Reason	Tests
Failed junit tests	hadoop.hdfs.TestRollingUpgrade

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/10/artifact/out/Dockerfile
GITHUB PR	#4311
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname	Linux e0ad7bb622c3 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 7cad62f38d6d6db534b54d5076babf9ab5f59e6e
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/10/testReport/
Max. process+thread count	3620 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/10/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-08-24T07:27:03Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 37s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 6 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	15m 29s		Maven dependency ordering for branch
+1 💚	mvninstall	25m 31s		trunk passed
+1 💚	compile	23m 15s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	20m 40s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	4m 22s		trunk passed
+1 💚	mvnsite	7m 39s		trunk passed
+1 💚	javadoc	6m 35s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	6m 46s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	12m 18s		trunk passed
+1 💚	shadedclient	22m 27s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	1m 2s		Maven dependency ordering for patch
+1 💚	mvninstall	4m 12s		the patch passed
+1 💚	compile	22m 30s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	22m 30s		the patch passed
+1 💚	compile	20m 50s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
-1 ❌	javac	20m 50s	/results-compile-javac-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt	root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~~20.04-b07 generated 1 new + 2643 unchanged - 1 fixed = 2644 total (was 2644)
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	4m 18s	/results-checkstyle-root.txt	root: The patch generated 4 new + 236 unchanged - 9 fixed = 240 total (was 245)
+1 💚	mvnsite	7m 35s		the patch passed
+1 💚	javadoc	6m 15s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	6m 47s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	12m 54s		the patch passed
+1 💚	shadedclient	22m 51s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	18m 41s		hadoop-common in the patch passed.
+1 💚	unit	3m 17s		hadoop-hdfs-client in the patch passed.
+1 💚	unit	241m 20s		hadoop-hdfs in the patch passed.
+1 💚	unit	23m 3s		hadoop-hdfs-rbf in the patch passed.
+1 💚	asflicense	1m 33s		The patch does not generate ASF License warnings.
		548m 13s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/24/artifact/out/Dockerfile
GITHUB PR	#4311
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 69a4b5a7bb43 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 7ef4074719633503d20b6c0b2e79a9c99bf227e8
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/24/testReport/
Max. process+thread count	3482 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/24/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-08-25T07:22:48Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 44s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 4 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	15m 7s		Maven dependency ordering for branch
+1 💚	mvninstall	25m 51s		trunk passed
+1 💚	compile	23m 16s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	20m 36s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	4m 7s		trunk passed
+1 💚	mvnsite	7m 8s		trunk passed
+1 💚	javadoc	5m 53s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	5m 42s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	11m 15s		trunk passed
+1 💚	shadedclient	21m 55s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	1m 10s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 55s		the patch passed
+1 💚	compile	22m 39s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	22m 39s		the patch passed
+1 💚	compile	20m 34s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
-1 ❌	javac	20m 34s	/results-compile-javac-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt	root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~~20.04-b07 generated 1 new + 2643 unchanged - 1 fixed = 2644 total (was 2644)
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	4m 4s	/results-checkstyle-root.txt	root: The patch generated 4 new + 14 unchanged - 9 fixed = 18 total (was 23)
+1 💚	mvnsite	6m 46s		the patch passed
+1 💚	javadoc	5m 26s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	5m 44s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	12m 13s		the patch passed
+1 💚	shadedclient	22m 24s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	18m 26s		hadoop-common in the patch passed.
+1 💚	unit	2m 56s		hadoop-hdfs-client in the patch passed.
+1 💚	unit	236m 53s		hadoop-hdfs in the patch passed.
+1 💚	unit	23m 49s		hadoop-hdfs-rbf in the patch passed.
+1 💚	asflicense	1m 36s		The patch does not generate ASF License warnings.
		534m 56s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/25/artifact/out/Dockerfile
GITHUB PR	#4311
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 2b526f6d7f64 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 283ee928af7994513974fd81d159e97678fc63b5
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/25/testReport/
Max. process+thread count	3113 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/25/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

...p-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/ClientGSIContext.java

...p-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/NamespaceStateId.java

...rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/FederatedNamespaceIds.java

...-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterStateIdContext.java

hadoop-yetus · 2022-09-07T12:31:30Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 44s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 4 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	15m 12s		Maven dependency ordering for branch
+1 💚	mvninstall	25m 49s		trunk passed
+1 💚	compile	23m 11s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	compile	20m 32s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	4m 10s		trunk passed
+1 💚	mvnsite	6m 43s		trunk passed
+1 💚	javadoc	5m 37s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	5m 58s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	11m 18s		trunk passed
+1 💚	shadedclient	22m 6s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 31s		Maven dependency ordering for patch
+1 💚	mvninstall	4m 4s		the patch passed
+1 💚	compile	22m 35s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javac	22m 35s		the patch passed
+1 💚	compile	20m 31s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
-1 ❌	javac	20m 31s	/results-compile-javac-root-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07.txt	root-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~~20.04-b07 with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~~20.04-b07 generated 1 new + 2645 unchanged - 1 fixed = 2646 total (was 2646)
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	4m 2s	/results-checkstyle-root.txt	root: The patch generated 8 new + 175 unchanged - 8 fixed = 183 total (was 183)
+1 💚	mvnsite	6m 39s		the patch passed
+1 💚	javadoc	5m 14s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	6m 2s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	11m 50s		the patch passed
+1 💚	shadedclient	23m 48s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	19m 7s		hadoop-common in the patch passed.
+1 💚	unit	3m 5s		hadoop-hdfs-client in the patch passed.
-1 ❌	unit	241m 23s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
-1 ❌	unit	24m 15s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt	hadoop-hdfs-rbf in the patch passed.
-1 ❌	asflicense	1m 38s	/results-asflicense.txt	The patch generated 1 ASF License warnings.
		540m 39s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.namenode.ha.TestObserverNode
	hadoop.hdfs.TestRollingUpgrade
	hadoop.hdfs.server.federation.router.TestRBFConfigFields

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/26/artifact/out/Dockerfile
GITHUB PR	#4311
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 2c215e481077 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 856f63a974666da8ef022bbe9a43fe916132ed55
Default Java	Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/26/testReport/
Max. process+thread count	3398 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/26/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

…propagate it between routers and clients.

omalley

I have a couple of top level concerns:

All clients will get all of the namespaces in their federated state ids.
If the number of name spaces goes over the maximum, currently we'll msync to all of the namespaces, which will destroy performance.
It looks to me like Server.getCurCall() is set when both the AlignmentContexts are updated (from the NN and to the client). That implies that we could use them to make smaller changes in this patch and only include the namespaces that the specific client cares about.

hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcConstants.java

...s-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/NameNodeProxiesClient.java

...rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/FederatedNamespaceIds.java

...-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/PoolAlignmentContext.java

...-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java

...-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcServer.java

...-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterStateIdContext.java

hadoop-yetus · 2022-09-08T03:18:33Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 47s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+0 🆗	xmllint	0m 1s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 4 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	22m 21s		Maven dependency ordering for branch
+1 💚	mvninstall	29m 5s		trunk passed
+1 💚	compile	25m 17s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	compile	22m 52s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	4m 23s		trunk passed
+1 💚	mvnsite	6m 40s		trunk passed
+1 💚	javadoc	5m 30s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	5m 50s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	14m 28s		trunk passed
+1 💚	shadedclient	22m 32s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 26s		Maven dependency ordering for patch
+1 💚	mvninstall	4m 8s		the patch passed
+1 💚	compile	25m 16s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javac	25m 16s		the patch passed
+1 💚	compile	22m 58s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
-1 ❌	javac	22m 58s	/results-compile-javac-root-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07.txt	root-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~~20.04-b07 with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~~20.04-b07 generated 1 new + 2645 unchanged - 1 fixed = 2646 total (was 2646)
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	3m 58s	/results-checkstyle-root.txt	root: The patch generated 2 new + 175 unchanged - 8 fixed = 177 total (was 183)
+1 💚	mvnsite	6m 49s		the patch passed
+1 💚	javadoc	5m 31s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	6m 1s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	13m 9s		the patch passed
+1 💚	shadedclient	22m 7s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	18m 35s		hadoop-common in the patch passed.
+1 💚	unit	3m 6s		hadoop-hdfs-client in the patch passed.
+1 💚	unit	249m 6s		hadoop-hdfs in the patch passed.
+1 💚	unit	25m 19s		hadoop-hdfs-rbf in the patch passed.
+1 💚	asflicense	1m 44s		The patch does not generate ASF License warnings.
		572m 20s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/27/artifact/out/Dockerfile
GITHUB PR	#4311
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname	Linux d637fe4f6ec8 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / bbaf062f4bff89c79e005f53b39812ad55a9c425
Default Java	Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/27/testReport/
Max. process+thread count	3135 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/27/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-09-08T03:28:15Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 51s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 4 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	22m 55s		Maven dependency ordering for branch
+1 💚	mvninstall	28m 23s		trunk passed
+1 💚	compile	26m 11s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	compile	22m 31s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	4m 36s		trunk passed
+1 💚	mvnsite	6m 55s		trunk passed
+1 💚	javadoc	5m 19s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	5m 40s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	11m 33s		trunk passed
+1 💚	shadedclient	22m 5s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 32s		Maven dependency ordering for patch
+1 💚	mvninstall	4m 42s		the patch passed
+1 💚	compile	25m 38s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javac	25m 38s		the patch passed
+1 💚	compile	22m 20s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	javac	22m 20s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	4m 24s	/results-checkstyle-root.txt	root: The patch generated 2 new + 175 unchanged - 8 fixed = 177 total (was 183)
+1 💚	mvnsite	7m 11s		the patch passed
+1 💚	javadoc	5m 28s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	5m 37s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	12m 9s		the patch passed
+1 💚	shadedclient	22m 19s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	19m 7s		hadoop-common in the patch passed.
+1 💚	unit	3m 6s		hadoop-hdfs-client in the patch passed.
+1 💚	unit	250m 39s		hadoop-hdfs in the patch passed.
+1 💚	unit	24m 49s		hadoop-hdfs-rbf in the patch passed.
+1 💚	asflicense	1m 36s		The patch does not generate ASF License warnings.
		571m 12s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/28/artifact/out/Dockerfile
GITHUB PR	#4311
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname	Linux cc3a7c2f4d93 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `30497ad`
Default Java	Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/28/testReport/
Max. process+thread count	3262 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/28/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-09-09T08:40:14Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 35s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 4 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 48s		Maven dependency ordering for branch
+1 💚	mvninstall	25m 45s		trunk passed
+1 💚	compile	23m 12s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	compile	20m 39s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	4m 12s		trunk passed
+1 💚	mvnsite	6m 40s		trunk passed
+1 💚	javadoc	5m 19s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	5m 48s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	11m 49s		trunk passed
+1 💚	shadedclient	22m 5s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 28s		Maven dependency ordering for patch
+1 💚	mvninstall	4m 4s		the patch passed
+1 💚	compile	22m 26s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javac	22m 26s		the patch passed
+1 💚	compile	20m 39s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	javac	20m 39s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	3m 57s	/results-checkstyle-root.txt	root: The patch generated 4 new + 175 unchanged - 8 fixed = 179 total (was 183)
+1 💚	mvnsite	6m 39s		the patch passed
+1 💚	javadoc	5m 11s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	5m 51s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	12m 0s		the patch passed
+1 💚	shadedclient	22m 30s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	18m 42s		hadoop-common in the patch passed.
+1 💚	unit	3m 5s		hadoop-hdfs-client in the patch passed.
-1 ❌	unit	238m 52s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	unit	23m 47s		hadoop-hdfs-rbf in the patch passed.
+1 💚	asflicense	1m 38s		The patch does not generate ASF License warnings.
		535m 16s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
	hadoop.hdfs.TestRollingUpgrade

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/29/artifact/out/Dockerfile
GITHUB PR	#4311
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname	Linux f49301d82fea 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `8b59b80`
Default Java	Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/29/testReport/
Max. process+thread count	3152 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/29/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

omalley

Just a few minor formatting issues, but otherwise looks good.

hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcConstants.java

...p-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/ClientGSIContext.java

omalley

+1 LGTM

Thank you, Simba!

hadoop-yetus · 2022-09-10T04:59:42Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 37s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 4 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	15m 4s		Maven dependency ordering for branch
+1 💚	mvninstall	25m 31s		trunk passed
+1 💚	compile	23m 7s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	compile	20m 34s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	4m 9s		trunk passed
+1 💚	mvnsite	7m 1s		trunk passed
+1 💚	javadoc	5m 37s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	5m 46s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	11m 27s		trunk passed
+1 💚	shadedclient	21m 36s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 33s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 58s		the patch passed
+1 💚	compile	22m 21s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javac	22m 21s		the patch passed
+1 💚	compile	20m 38s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	javac	20m 38s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	4m 6s	/results-checkstyle-root.txt	root: The patch generated 4 new + 175 unchanged - 8 fixed = 179 total (was 183)
+1 💚	mvnsite	6m 45s		the patch passed
+1 💚	javadoc	5m 19s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
-1 ❌	javadoc	1m 44s	/results-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07.txt	hadoop-hdfs-project_hadoop-hdfs-rbf-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~~20.04-b07 with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~~20.04-b07 generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)
-1 ❌	spotbugs	1m 2s	/patch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-rbf.txt	hadoop-hdfs-rbf in the patch failed.
+1 💚	shadedclient	24m 12s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	18m 33s		hadoop-common in the patch passed.
+1 💚	unit	3m 3s		hadoop-hdfs-client in the patch passed.
+1 💚	unit	236m 0s		hadoop-hdfs in the patch passed.
-1 ❌	unit	1m 22s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt	hadoop-hdfs-rbf in the patch failed.
+1 💚	asflicense	1m 38s		The patch does not generate ASF License warnings.
		509m 0s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/30/artifact/out/Dockerfile
GITHUB PR	#4311
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname	Linux 9a1fead4a5bd 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `faa6493`
Default Java	Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/30/testReport/
Max. process+thread count	3275 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4311/30/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

…propagate it between routers and clients. Fixes apache#4311 Signed-off-by: Owen O'Malley <oomalley@linkedin.com>

LiuGuH · 2023-09-12T06:57:27Z

The design doc https://issues.apache.org/jira/secure/attachment/13047193/observer_reads_in_rbf_proposal_simbadzina_v2.pdf is very helpful .
But the Third party communication(pdf) in the observer_reads_in_rbf_proposal_simbadzina_v2.pdf is too blurry to read , and the pdf link https://drive.google.com/file/d/1851oaVeayiKKbNFSa93G5CS-bXXZY7BM/view?usp=sharing is does not exist.

Can anyone put it again？ Thanks very much

simbadzina · 2023-09-12T15:19:03Z

The design doc https://issues.apache.org/jira/secure/attachment/13047193/observer_reads_in_rbf_proposal_simbadzina_v2.pdf is very helpful . But the Third party communication(pdf) in the observer_reads_in_rbf_proposal_simbadzina_v2.pdf is too blurry to read , and the pdf link https://drive.google.com/file/d/1851oaVeayiKKbNFSa93G5CS-bXXZY7BM/view?usp=sharing is does not exist.

Can anyone put it again？ Thanks very much

I've replaced the file with one with refreshed links. https://issues.apache.org/jira/secure/attachment/13062835/observer_reads_in_rbf_proposal_simbadzina_v2.pdf

I've uploaded the third party reads pdf to Jira as well: https://issues.apache.org/jira/secure/attachment/13062830/rbf_observer_reads%20-%20third_party_reads.pdf

…propagate it between routers and clients. Fixes apache#4311 Signed-off-by: Owen O'Malley <oomalley@linkedin.com>

…propagate it between routers and clients. Fixes apache#4311 Signed-off-by: Owen O'Malley <oomalley@linkedin.com> ACLOVERRIDE

…propagate it between routers and clients. Fixes apache#4311 Signed-off-by: Owen O'Malley <oomalley@linkedin.com>

simbadzina force-pushed the feature/HDFS-13522-ipc branch from 4d719a2 to 2b51acb Compare May 16, 2022 19:30

simbadzina force-pushed the feature/HDFS-13522-ipc branch from 2b51acb to 4286ba8 Compare May 17, 2022 05:40

simbadzina mentioned this pull request May 17, 2022

HDFS-16767. RBF: Support observer node from Router-Based Federation #4127

Closed

simbadzina force-pushed the feature/HDFS-13522-ipc branch from 4286ba8 to 4a3b31a Compare May 26, 2022 19:56

simbadzina force-pushed the feature/HDFS-13522-ipc branch from 4a3b31a to 43853ef Compare May 31, 2022 19:57

simbadzina force-pushed the feature/HDFS-13522-ipc branch from 43853ef to 41312cb Compare June 3, 2022 20:49

melissayou approved these changes Jun 8, 2022

View reviewed changes

...p-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/ClientGSIContext.java Outdated Show resolved Hide resolved

...s-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/NameNodeProxiesClient.java Outdated Show resolved Hide resolved

hchaverri reviewed Jun 8, 2022

View reviewed changes

...p-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/ClientGSIContext.java Outdated Show resolved Hide resolved

hchaverri reviewed Jun 8, 2022

View reviewed changes

...dfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/ConnectionManager.java Outdated Show resolved Hide resolved

hchaverri reviewed Jun 8, 2022

View reviewed changes

...dfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/ConnectionManager.java Outdated Show resolved Hide resolved

ZanderXu reviewed Jun 9, 2022

View reviewed changes

omalley requested changes Jun 14, 2022

View reviewed changes

ZanderXu mentioned this pull request Jun 15, 2022

HDFS-13522. IPC changes to support observer reads through routers. #4441

Closed

hchaverri approved these changes Jun 17, 2022

View reviewed changes

simbadzina force-pushed the feature/HDFS-13522-ipc branch from 82a59d0 to 38ee8b1 Compare June 20, 2022 07:05

simbadzina force-pushed the feature/HDFS-13522-ipc branch from 38ee8b1 to 7cad62f Compare June 21, 2022 19:02

simbadzina force-pushed the feature/HDFS-13522-ipc branch from 7cad62f to 97bd692 Compare June 30, 2022 23:44

simbadzina mentioned this pull request Jun 30, 2022

[Draft] HDFS-13522: Allow routers to use observer namenode without an msync on even read. [Not ready for review] #4523

Closed

4 tasks

simbadzina force-pushed the feature/HDFS-13522-ipc branch from ef4d26c to 7ef4074 Compare August 23, 2022 22:17

simbadzina force-pushed the feature/HDFS-13522-ipc branch from 7ef4074 to 283ee92 Compare August 24, 2022 22:26

omalley requested changes Aug 30, 2022

View reviewed changes

simbadzina force-pushed the feature/HDFS-13522-ipc branch from 283ee92 to 856f63a Compare September 7, 2022 03:29

simbadzina force-pushed the feature/HDFS-13522-ipc branch from 856f63a to bbaf062 Compare September 7, 2022 17:44

simbadzina added 2 commits September 7, 2022 10:54

HDFS-13522: Add federated nameservices states to client protocol and …

a243ca8

…propagate it between routers and clients.

Avoiding denial of service between clients.

30497ad

simbadzina force-pushed the feature/HDFS-13522-ipc branch from bbaf062 to 30497ad Compare September 7, 2022 17:55

omalley requested changes Sep 8, 2022

View reviewed changes

Addressing review comments. Mostly refactoring.

8b59b80

omalley requested changes Sep 9, 2022

View reviewed changes

hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcConstants.java Outdated Show resolved Hide resolved

...p-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/ClientGSIContext.java Outdated Show resolved Hide resolved

Formatting fixes.

faa6493

omalley approved these changes Sep 9, 2022

View reviewed changes

omalley closed this in e77d54d Sep 9, 2022

simbadzina added a commit to simbadzina/hadoop that referenced this pull request Sep 13, 2022

HDFS-13522: Add federated nameservices states to client protocol and …

7cda0e5

…propagate it between routers and clients. Fixes apache#4311 Signed-off-by: Owen O'Malley <oomalley@linkedin.com>

LiuGuH pushed a commit to LiuGuH/hadoop that referenced this pull request Mar 29, 2024

HDFS-13522: Add federated nameservices states to client protocol and …

8d4c774

…propagate it between routers and clients. Fixes apache#4311 Signed-off-by: Owen O'Malley <oomalley@linkedin.com>

simbadzina deleted the feature/HDFS-13522-ipc branch June 28, 2024 20:22

LiuGuH pushed a commit to LiuGuH/hadoop that referenced this pull request Jul 4, 2024

HDFS-13522: Add federated nameservices states to client protocol and …

c927023

…propagate it between routers and clients. Fixes apache#4311 Signed-off-by: Owen O'Malley <oomalley@linkedin.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HDFS-13522: IPC changes to support observer reads through routers. #4311

HDFS-13522: IPC changes to support observer reads through routers. #4311

simbadzina commented May 16, 2022

hadoop-yetus commented May 16, 2022

hadoop-yetus commented May 17, 2022

hadoop-yetus commented May 17, 2022

simbadzina commented May 18, 2022 •

edited

Loading

hadoop-yetus commented May 27, 2022

hadoop-yetus commented Jun 1, 2022

hadoop-yetus commented Jun 4, 2022

melissayou left a comment

ZanderXu left a comment

ZanderXu commented Jun 15, 2022

hadoop-yetus commented Jun 16, 2022

hadoop-yetus commented Jun 17, 2022

hadoop-yetus commented Jun 20, 2022

hadoop-yetus commented Jun 22, 2022

hadoop-yetus commented Aug 24, 2022

hadoop-yetus commented Aug 25, 2022

hadoop-yetus commented Sep 7, 2022

omalley left a comment

hadoop-yetus commented Sep 8, 2022

hadoop-yetus commented Sep 8, 2022

hadoop-yetus commented Sep 9, 2022

omalley left a comment

omalley left a comment

hadoop-yetus commented Sep 10, 2022

LiuGuH commented Sep 12, 2023 •

edited

Loading

simbadzina commented Sep 12, 2023

HDFS-13522: IPC changes to support observer reads through routers. #4311

HDFS-13522: IPC changes to support observer reads through routers. #4311

Conversation

simbadzina commented May 16, 2022

Description of PR

How was this patch tested?

For code changes:

hadoop-yetus commented May 16, 2022

hadoop-yetus commented May 17, 2022

hadoop-yetus commented May 17, 2022

simbadzina commented May 18, 2022 • edited Loading

hadoop-yetus commented May 27, 2022

hadoop-yetus commented Jun 1, 2022

hadoop-yetus commented Jun 4, 2022

melissayou left a comment

Choose a reason for hiding this comment

ZanderXu left a comment

Choose a reason for hiding this comment

ZanderXu commented Jun 15, 2022

hadoop-yetus commented Jun 16, 2022

hadoop-yetus commented Jun 17, 2022

hadoop-yetus commented Jun 20, 2022

hadoop-yetus commented Jun 22, 2022

hadoop-yetus commented Aug 24, 2022

hadoop-yetus commented Aug 25, 2022

hadoop-yetus commented Sep 7, 2022

omalley left a comment

Choose a reason for hiding this comment

hadoop-yetus commented Sep 8, 2022

hadoop-yetus commented Sep 8, 2022

hadoop-yetus commented Sep 9, 2022

omalley left a comment

Choose a reason for hiding this comment

omalley left a comment

Choose a reason for hiding this comment

hadoop-yetus commented Sep 10, 2022

LiuGuH commented Sep 12, 2023 • edited Loading

simbadzina commented Sep 12, 2023

simbadzina commented May 18, 2022 •

edited

Loading

LiuGuH commented Sep 12, 2023 •

edited

Loading