Skip to content

HDFS-17706. TestBlockTokenWithDFSStriped fails due to closed streams #7275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2025
Merged

HDFS-17706. TestBlockTokenWithDFSStriped fails due to closed streams #7275

merged 1 commit into from
Jan 13, 2025

Conversation

kokon191
Copy link
Contributor

@kokon191 kokon191 commented Jan 8, 2025

No description provided.

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 19s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 21m 51s trunk passed
+1 💚 compile 0m 45s trunk passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚 compile 0m 39s trunk passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu220.04-ga
+1 💚 checkstyle 0m 36s trunk passed
+1 💚 mvnsite 0m 42s trunk passed
+1 💚 javadoc 0m 43s trunk passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚 javadoc 1m 6s trunk passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu220.04-ga
+1 💚 spotbugs 1m 41s trunk passed
+1 💚 shadedclient 20m 1s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 35s the patch passed
+1 💚 compile 0m 36s the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚 javac 0m 36s the patch passed
+1 💚 compile 0m 33s the patch passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu220.04-ga
+1 💚 javac 0m 33s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 29s the patch passed
+1 💚 mvnsite 0m 38s the patch passed
+1 💚 javadoc 0m 31s the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚 javadoc 1m 0s the patch passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu220.04-ga
+1 💚 spotbugs 1m 45s the patch passed
+1 💚 shadedclient 20m 1s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 199m 34s hadoop-hdfs in the patch passed.
+1 💚 asflicense 0m 30s The patch does not generate ASF License warnings.
273m 55s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7275/1/artifact/out/Dockerfile
GITHUB PR #7275
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 040c914f6d96 5.15.0-124-generic #134-Ubuntu SMP Fri Sep 27 20:20:17 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 32d805f
Default Java Private Build-1.8.0_432-8u432-gaus1-0ubuntu220.04-ga
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_432-8u432-gaus1-0ubuntu220.04-ga
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7275/1/testReport/
Max. process+thread count 3686 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7275/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Hexiaoqiao
Hexiaoqiao reviewed Jan 12, 2025
View reviewed changes
...-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockTokenWithDFS.java
@@ -582,6 +582,9 @@ protected void doTestRead(Configuration conf, MiniDFSCluster cluster,

// restart the namenode to allow DFSClient to re-fetch tokens
cluster.restartNameNode(0);
// Reopen closed streams
in1 = fs.open(fileToRead);
in3 = fs.open(fileToRead);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your works here. Not familiar with this unit test, just confused where are this input stream closed? Thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review. The exceptions happen in the 2 assertFalse(checkFile()) lines right above and the streams were closed during exception handling.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, try to explore the code but not see any explicit close stream operation, anything I skipped? Thanks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hexiaoqiao Sir, inputStream is closed here: https://github.com/harris233/hadoop/blob/e73f432f56ca8c209cff0a7f3077522b5e76e0d7/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/StripeReader.java#L356C7-L356C28

This code was introduced by HDFS-17080

image image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. +1.

@Hexiaoqiao Hexiaoqiao mentioned this pull request Jan 12, 2025
Merged
@Hexiaoqiao Hexiaoqiao merged commit 266dad1 into apache:trunk Jan 13, 2025
4 checks passed
@Hexiaoqiao
Copy link
Contributor

Committed to trunk. Thanks @kokon191 !

@Hexiaoqiao
Copy link
Contributor

@kokon191 Would you mind to check if we could cherry-pick to branch-3.4 smoothly or need to prepare another PR for branch-3.4?

@kokon191
Copy link
Contributor Author

@Hexiaoqiao The commit can be cherry picked straight to branch-3.4 without any conflict

asfgit pushed a commit that referenced this pull request Jan 13, 2025
@kokon191 @Hexiaoqiao
HDFS-17706. TestBlockTokenWithDFSStriped fails due to closed streams. (…
77844e9 
…#7275). Contribtued by Felix N.

Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
(cherry picked from commit 266dad1)
@Hexiaoqiao
Copy link
Contributor

Great, check-pick to branch-3.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hexiaoqiao Hexiaoqiao Hexiaoqiao approved these changes

@ferhui ferhui ferhui approved these changes

+1 more reviewer

@hfutatzhanghb hfutatzhanghb hfutatzhanghb approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
HDFS trunk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kokon191 @hadoop-yetus @Hexiaoqiao @ferhui @hfutatzhanghb @kokonguyen191