HBASE-23882: Experimenting with low config settings. #1194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
Rerunning build to see if the failures repeat. |
saintstack
reviewed
Feb 25, 2020
There was a problem hiding this comment.
I just added in old defaults for contrast. A few of these config changes could make a big difference I think. Needs to be done in hbase-*/src/test/resources/hbase-site.xml though. Actually, if you look in the hbase-site.xml you'll see some of these configs already set down.
| // conf.setInt("dfs.datanode.max.transfer.threads", 5); | ||
| // conf.setInt("dfs.client.file-block-storage-locations.num-threads", 5); | ||
| } | ||
|
|
There was a problem hiding this comment.
FYI, the way we do this usually for tests is to put these settings into hbase-*/src/test/resources/hbase-site.xml
| // can't set this for every test currently | ||
| // conf.set("hbase.regionserver.hostname", "127.0.0.1"); | ||
|
|
||
| conf.setInt("hbase.hfilearchiver.thread.pool.max", 2); |
| // conf.set("hbase.regionserver.hostname", "127.0.0.1"); | ||
|
|
||
| conf.setInt("hbase.hfilearchiver.thread.pool.max", 2); | ||
| conf.setInt("hbase.loadincremental.threads.max", 3); |
There was a problem hiding this comment.
This one is sized by processor count. Rather than hard-code it, keep it based on processor count but divide by 2 or 4 w/ minimum 3?
| conf.setInt("hbase.loadincremental.threads.max", 3); | ||
|
|
||
|
|
||
| conf.setInt("hbase.client.sync.wait.timeout.msec", 30000); |
There was a problem hiding this comment.
Default is 10min which is crazy for a test, yes. Test general timeout is 13mins IIRC.
|
|
||
|
|
||
| conf.setInt("hbase.client.sync.wait.timeout.msec", 30000); | ||
| conf.setInt("zookeeper.recovery.retry", 5); |
There was a problem hiding this comment.
Default is 30. Too much for a test. This looks good.
| // conf.setInt(HConstants.ZOOKEEPER_MAX_CLIENT_CNXNS, 5); | ||
|
|
||
| conf.setInt("hbase.hconnection.threads.max", 30); | ||
| conf.setInt("hbase.hconnection.threads.keepalivetime", 30); |
|
|
||
| conf.setInt("hbase.hconnection.threads.max", 30); | ||
| conf.setInt("hbase.hconnection.threads.keepalivetime", 30); | ||
| conf.setInt(HConstants.HBASE_CLIENT_MAX_TOTAL_TASKS, 10); |
There was a problem hiding this comment.
This a repeat? Above you have it set to 3 if I'm reading this right.
|
|
||
|
|
||
|
|
||
| conf.setInt(HConstants.REGION_SERVER_HANDLER_COUNT, 2); |
There was a problem hiding this comment.
Default is 30. 2 is probably too few? Maybe not.
|
|
||
|
|
||
| conf.setInt(HConstants.REGION_SERVER_HANDLER_COUNT, 2); | ||
| conf.setInt("hbase.master.procedure.threads", 1); |
There was a problem hiding this comment.
Default is 16. Make it based off CPU count? Cutting it down is good idea.
| conf.setInt(HConstants.REGION_SERVER_HANDLER_COUNT, 2); | ||
| conf.setInt("hbase.master.procedure.threads", 1); | ||
|
|
||
| conf.setInt("dfs.namenode.handler.count", 5); |
|
💔 -1 overall
This message was automatically generated. |
saintstack
reviewed
Apr 11, 2020
There was a problem hiding this comment.
I think this PR is stale now @markrmiller I used it for inspiration/stole-from-it doing edits to our test default-site.xml files over in HBASE-23956.
Should we resolve this PR and its JIRA (JIRA keeps getting his w/ build comments when PRs are left open). Thanks.
|
Closing out. I hijacked the changes here over in HBASE-23956 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is some initial experimentation with bringing mini cluster settings down to scale.
To start, I've been shooting for pretty minimal.
I've pulled this out of an experimental branch and so some work may still be in order to find any tests these settings are too low for.
I will continue to update this as I fine tune. I also have some other changes I'd like to dig out around thread pool sizing if I can find them again. I'll likely update again early next week.