Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-22258 Removed deprecated methods in VisibilityClient #159

Merged
merged 1 commit into from
Apr 23, 2019

Conversation

HorizonNet
Copy link
Contributor

No description provided.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 25 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 255 master passed
+1 compile 27 master passed
+1 checkstyle 34 master passed
+1 shadedjars 262 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 60 master passed
+1 javadoc 20 master passed
_ Patch Compile Tests _
+1 mvninstall 242 the patch passed
+1 compile 25 the patch passed
+1 javac 25 the patch passed
+1 checkstyle 30 hbase-client: The patch generated 0 new + 19 unchanged - 19 fixed = 19 total (was 38)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 261 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 505 Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1 findbugs 67 the patch passed
+1 javadoc 21 the patch passed
_ Other Tests _
+1 unit 201 hbase-client in the patch passed.
+1 asflicense 14 The patch does not generate ASF License warnings.
2127
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-159/1/artifact/out/Dockerfile
GITHUB PR #159
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux d85b45af76e0 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 12bcb87
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-159/1/testReport/
Max. process+thread count 289 (vs. ulimit of 10000)
modules C: hbase-client U: hbase-client
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-159/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 28 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 255 master passed
+1 compile 29 master passed
+1 checkstyle 32 master passed
+1 shadedjars 276 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 62 master passed
+1 javadoc 21 master passed
_ Patch Compile Tests _
+1 mvninstall 249 the patch passed
+1 compile 25 the patch passed
+1 javac 25 the patch passed
+1 checkstyle 31 hbase-client: The patch generated 0 new + 19 unchanged - 19 fixed = 19 total (was 38)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 263 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 518 Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1 findbugs 75 the patch passed
+1 javadoc 20 the patch passed
_ Other Tests _
+1 unit 205 hbase-client in the patch passed.
+1 asflicense 11 The patch does not generate ASF License warnings.
2166
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-159/2/artifact/out/Dockerfile
GITHUB PR #159
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux a22287dd0ab5 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / f30d6c9
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-159/2/testReport/
Max. process+thread count 294 (vs. ulimit of 10000)
modules C: hbase-client U: hbase-client
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-159/2/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@saintstack saintstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending confirm that these methods have been deprecated since 2.0.0. Thanks.

@HorizonNet
Copy link
Contributor Author

@saintstack Re-checked it again. The methods were deprecated in HBASE-13620, which has 2.0.0 set as the fix version.

Copy link
Contributor

@saintstack saintstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking. Perhaps note in RN the issue that deprecated them.

@HorizonNet HorizonNet merged commit 3dfa98f into apache:master Apr 23, 2019
@HorizonNet HorizonNet deleted the HBASE-22258 branch April 23, 2019 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants