HBASE-22344 Documented the deprecation of public and limited private … #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
z-york
reviewed
Apr 30, 2019
| @@ -857,19 +863,31 @@ public void removeCoprocessor(String className) { | |||
| public static final HTableDescriptor NAMESPACE_TABLEDESC | |||
| = new HTableDescriptor(TableDescriptorBuilder.NAMESPACE_TABLEDESC); | |||
|
|
|||
| /** | |||
| * @deprecated since 0.94.1 | |||
There was a problem hiding this comment.
I'm assuming there will be a follow-up task to remove anything that can be removed?
There was a problem hiding this comment.
Yes. This ticket is based on a discussion we had on the dev list. We have some deprecations where it isn't documented in the code in what release the appropriate functionality was deprecated. There are already some removals in progress, because removing everything at once will end up in a mess.
|
💔 -1 overall
This message was automatically generated. |
saintstack
approved these changes
May 1, 2019
| @@ -791,7 +794,11 @@ default int getRpcTimeout() { | |||
| * | |||
| * @param rpcTimeout the timeout of each rpc request in millisecond. | |||
| * | |||
| * @deprecated Use setReadRpcTimeout or setWriteRpcTimeout instead | |||
| * @deprecated since 1.4.0 and will be removed in 3.0.0. Use {@link #setReadRpcTimeout(int)} or | |||
There was a problem hiding this comment.
This seems a little strange. Was there a 1.4.0 when 2.0.0 was released?
| @@ -878,6 +912,10 @@ public long getReadRpcTimeout(TimeUnit unit) { | |||
| throw new UnsupportedOperationException(); | |||
| } | |||
|
|
|||
| /** | |||
| * @deprecated since 1.4.0 and will be removed in 3.0.0. Will be removed without a replacement. | |||
There was a problem hiding this comment.
See comment above.
|
Updated the PR to fix the Checkstyle and Javadoc issues from the last build. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
HorizonNet
force-pushed
the
HBASE-22344
branch
2 times, most recently
from
eaa401e
to
a05e481
Compare
|
💔 -1 overall
This message was automatically generated. |
|
Re-running checks. This is a nice patch. Lets get it in. |
|
Re-triggered the build, because it seems that the last one got aborted. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
asfgit
pushed a commit
that referenced
this pull request
Jun 17, 2019
…APIs (#208) Signed-off-by: stack <stack@apache.org>
asfgit
pushed a commit
that referenced
this pull request
Jun 17, 2019
…APIs (#208) Signed-off-by: stack <stack@apache.org>
asfgit
pushed a commit
that referenced
this pull request
Jun 17, 2019
…APIs (#208) Signed-off-by: stack <stack@apache.org>
asfgit
pushed a commit
that referenced
this pull request
Jun 17, 2019
…APIs (#208) Signed-off-by: stack <stack@apache.org>
asfgit
pushed a commit
that referenced
this pull request
Jun 17, 2019
…APIs (#208) Signed-off-by: stack <stack@apache.org>
asfgit
pushed a commit
that referenced
this pull request
Jun 17, 2019
…APIs (#208) Signed-off-by: stack <stack@apache.org>
asfgit
pushed a commit
that referenced
this pull request
Jun 17, 2019
…APIs (#208) Signed-off-by: stack <stack@apache.org>
wchevreuil
pushed a commit
to wchevreuil/hbase
that referenced
this pull request
Jul 3, 2019
…APIs (apache#208) Signed-off-by: stack <stack@apache.org>
symat
pushed a commit
to symat/hbase
that referenced
this pull request
Feb 17, 2021
…APIs (apache#208) Signed-off-by: stack <stack@apache.org> (cherry picked from commit 054dabb) Change-Id: Idf6774786b69b4882ef5ece167d519b51b2c3a5c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…APIs