HBASE-25277 postScannerFilterRow impacts Scan performance a lot in HBase 2.x #2675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pankaj72981
commented
Nov 18, 2020
pankaj72981
commented
- Added a check for Object class in RegionCoprocessorHost to avoid wrong initialization of hasCustomPostScannerFilterRow
- Removed duplication implementation from AccessController, VisibilityController & ConstraintProcessor (which are not required currently)
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
ramkrish86
reviewed
Nov 24, 2020
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java
Show resolved
Hide resolved
ramkrish86
approved these changes
Nov 24, 2020
Following region CPs were configured.
Yeah scan perf will have impact when number of CPs are more, for each row postScannerFilterRow will be call for each CPs. |
anoopsjohn
reviewed
Nov 25, 2020
| @@ -299,6 +304,11 @@ public RegionCoprocessorHost(final HRegion region, | |||
| } catch (NoSuchMethodException ignore) { | |||
| } | |||
| clazz = clazz.getSuperclass(); | |||
|
|
|||
There was a problem hiding this comment.
Actually change can be at begin of this loop
if (clazz == null) {
// we must have directly implemented RegionObserver
hasCustomPostScannerFilterRow = true;
break out;
}
In 1.x we have interface with no def impl. So we have to consider like hasCustomPostScannerFilterRow = true then. But in 2.x we have Interface with default impl. So its safe to change there to be hasCustomPostScannerFilterRow = false only.
In fact that check can be as urs
if (clazz == Object.class) {
break out;
}
There was a problem hiding this comment.
In fact that check can be as urs
if (clazz == Object.class) {
break out;
}
make sense, will update the PR.
pankaj72981
force-pushed
the
HBASE-25277
branch
from
dd0ae8d
to
a43d31b
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
anoopsjohn
reviewed
Nov 27, 2020
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java
Outdated
Show resolved
Hide resolved
|
Test issue anyway related? |
Test failures are not relevant. |
pankaj72981
force-pushed
the
HBASE-25277
branch
from
6653cee
to
af0dada
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
anoopsjohn
approved these changes
Dec 6, 2020
…iple CPs are configured and few CP override postScannerFilterRow
pankaj72981
force-pushed
the
HBASE-25277
branch
from
af0dada
to
c612df8
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Apache9
requested changes
Dec 6, 2020
| init(null); | ||
| } | ||
|
|
||
| public void init(Boolean flag) throws IOException { |
There was a problem hiding this comment.
Let's use private here? I do not think this method needs to be called in other classes?
| @@ -102,6 +102,11 @@ | |||
| // optimization: no need to call postScannerFilterRow, if no coprocessor implements it | |||
| private final boolean hasCustomPostScannerFilterRow; | |||
|
|
|||
| @VisibleForTesting | |||
There was a problem hiding this comment.
OK, VisibleForTesting...
We have a dicussion thread in the mailing list, and @apurtell concluded that we do not use annotation at all, just use a javadoc, and had already done a PR to remove all the VisibleForTesting annotations from our code base. I'm still trying to convince him to allow this annotation on IA.Private classes.
There is still no consensus yet, you can see the discussion in this PR
#2714
So here I suggest that we remove this annotation to align with the current rule in our code base first. But anyway, I think this is an example that developers want to use this annotation, so maybe @apurtell could change his opinion.
Thanks.
There was a problem hiding this comment.
Yeah, VisibleForTesting is useless. Will remove this.
Apache9
approved these changes
Dec 7, 2020
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
UT failures are not related. |
asfgit
pushed a commit
that referenced
this pull request
Dec 10, 2020
…ase 2.x (#2675) * HBASE-25277 postScannerFilterRow impacts Scan performance a lot in HBase 2.x 1. Added a check for Object class in RegionCoprocessorHost to avoid wrong initialization of hasCustomPostScannerFilterRow 2. Removed dummy implementation of postScannerFilterRow from AccessController, VisibilityController & ConstraintProcessor (which are not required currently) Signed-off-by Ramkrishna S Vasudevan <ramkrishna@apache.org> Signed-off-by Anoop Sam John <anoopsamjohn@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit fb6e498)
asfgit
pushed a commit
that referenced
this pull request
Dec 10, 2020
…ase 2.x (#2675) * HBASE-25277 postScannerFilterRow impacts Scan performance a lot in HBase 2.x 1. Added a check for Object class in RegionCoprocessorHost to avoid wrong initialization of hasCustomPostScannerFilterRow 2. Removed dummy implementation of postScannerFilterRow from AccessController, VisibilityController & ConstraintProcessor (which are not required currently) Signed-off-by Ramkrishna S Vasudevan <ramkrishna@apache.org> Signed-off-by Anoop Sam John <anoopsamjohn@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit fb6e498) (cherry picked from commit ec8eb65)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.