Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-26033 complement the admin operations in thrift2 after HBASE-21674 #3413

Closed
wants to merge 2 commits into from

Conversation

YutSean
Copy link
Contributor

@YutSean YutSean commented Jun 22, 2021

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 7m 31s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1 Compile Tests _
+1 💚 mvninstall 10m 3s branch-1 passed
+1 💚 compile 0m 32s branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 compile 0m 34s branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚 checkstyle 0m 44s branch-1 passed
-1 ❌ shadedjars 0m 19s branch has 7 errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 48s branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 javadoc 2m 43s branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+0 🆗 spotbugs 2m 15s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 2m 12s branch-1 passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 1s the patch passed
+1 💚 compile 0m 28s the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 javac 0m 28s the patch passed
+1 💚 compile 0m 36s the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚 javac 0m 36s the patch passed
-1 ❌ checkstyle 0m 36s hbase-thrift: The patch generated 1 new + 4 unchanged - 0 fixed = 5 total (was 4)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
-1 ❌ shadedjars 0m 13s patch has 7 errors when building our shaded downstream artifacts.
+1 💚 hadoopcheck 4m 29s Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚 javadoc 0m 30s the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 javadoc 2m 39s the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚 findbugs 2m 7s the patch passed
_ Other Tests _
-1 ❌ unit 0m 34s hbase-thrift in the patch failed.
+1 💚 asflicense 0m 23s The patch does not generate ASF License warnings.
43m 33s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3413/1/artifact/out/Dockerfile
GITHUB PR #3413
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 5be2f12cd282 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-3413/out/precommit/personality/provided.sh
git revision branch-1 / fd2f8a5
Default Java Azul Systems, Inc.-1.7.0_272-b10
Multi-JDK versions /usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10
shadedjars https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3413/1/artifact/out/branch-shadedjars.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3413/1/artifact/out/diff-checkstyle-hbase-thrift.txt
shadedjars https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3413/1/artifact/out/patch-shadedjars.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3413/1/artifact/out/patch-unit-hbase-thrift.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3413/1/testReport/
Max. process+thread count 87 (vs. ulimit of 10000)
modules C: hbase-thrift U: hbase-thrift
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3413/1/console
versions git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 39s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1 Compile Tests _
+1 💚 mvninstall 10m 13s branch-1 passed
+1 💚 compile 0m 31s branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 compile 0m 33s branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚 checkstyle 0m 44s branch-1 passed
-1 ❌ shadedjars 0m 23s branch has 7 errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 49s branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 javadoc 2m 45s branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+0 🆗 spotbugs 2m 16s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 2m 13s branch-1 passed
_ Patch Compile Tests _
+1 💚 mvninstall 1m 51s the patch passed
+1 💚 compile 0m 26s the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 javac 0m 26s the patch passed
+1 💚 compile 0m 33s the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚 javac 0m 33s the patch passed
+1 💚 checkstyle 0m 34s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
-1 ❌ shadedjars 0m 13s patch has 7 errors when building our shaded downstream artifacts.
+1 💚 hadoopcheck 4m 31s Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚 javadoc 0m 30s the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 javadoc 2m 42s the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚 findbugs 2m 5s the patch passed
_ Other Tests _
-1 ❌ unit 0m 35s hbase-thrift in the patch failed.
+1 💚 asflicense 0m 23s The patch does not generate ASF License warnings.
36m 44s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3413/2/artifact/out/Dockerfile
GITHUB PR #3413
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 4cd42266a8f9 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-3413/out/precommit/personality/provided.sh
git revision branch-1 / fd2f8a5
Default Java Azul Systems, Inc.-1.7.0_272-b10
Multi-JDK versions /usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10
shadedjars https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3413/2/artifact/out/branch-shadedjars.txt
shadedjars https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3413/2/artifact/out/patch-shadedjars.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3413/2/artifact/out/patch-unit-hbase-thrift.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3413/2/testReport/
Max. process+thread count 87 (vs. ulimit of 10000)
modules C: hbase-thrift U: hbase-thrift
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3413/2/console
versions git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@YutSean YutSean changed the title HBASE-21674 complement the admin operations in thrift2 HBASE-26033 complement the admin operations in thrift2 after HBASE-21674 Jun 25, 2021
@YutSean YutSean closed this Jun 25, 2021
@YutSean YutSean deleted the HBASE-21674 branch June 25, 2021 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants