HBASE-26125 Backport HBASE-25401 "Add trace support for async call in… #3543

taklwu · 2021-07-29T20:21:03Z

… rpc client" to branch-2

original commit is 2420286

… rpc client" to branch-2 2/17 commits of HBASE-22120

Apache-HBase · 2021-07-29T22:34:08Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 10s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 23s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 0s	branch-2 passed
+1 💚	compile	9m 18s	branch-2 passed
+1 💚	checkstyle	2m 28s	branch-2 passed
+1 💚	spotbugs	16m 34s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 40s	the patch passed
+1 💚	compile	9m 19s	the patch passed
+1 💚	cc	9m 19s	the patch passed
+1 💚	javac	9m 19s	the patch passed
+1 💚	checkstyle	2m 26s	root: The patch generated 0 new + 22 unchanged - 4 fixed = 22 total (was 26)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 2s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	13m 6s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	hbaseprotoc	6m 22s	the patch passed
+1 💚	spotbugs	17m 26s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 57s	The patch does not generate ASF License warnings.
		97m 2s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3543/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3543
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool xml
uname	Linux aa49cd5524a0 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `f049301`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	127 (vs. ulimit of 12500)
modules	C: hbase-protocol-shaded hbase-common hbase-client hbase-server . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3543/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-07-30T01:38:47Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 30s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 16s	branch-2 passed
+1 💚	compile	4m 2s	branch-2 passed
+1 💚	shadedjars	11m 38s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	7m 9s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 29s	Maven dependency ordering for patch
+1 💚	mvninstall	6m 40s	the patch passed
+1 💚	compile	4m 2s	the patch passed
+1 💚	javac	4m 2s	the patch passed
+1 💚	shadedjars	11m 19s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	6m 15s	the patch passed
		_ Other Tests _
+1 💚	unit	206m 10s	root in the patch passed.
		268m 37s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3543/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3543
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 2d0f1a3d1173 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `f049301`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3543/1/testReport/
Max. process+thread count	6109 (vs. ulimit of 12500)
modules	C: hbase-protocol-shaded hbase-common hbase-client hbase-server . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3543/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-07-30T06:08:19Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 25s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 43s	branch-2 passed
+1 💚	compile	8m 56s	branch-2 passed
+1 💚	checkstyle	2m 6s	branch-2 passed
+1 💚	spotbugs	15m 17s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 20s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 22s	the patch passed
+1 💚	compile	9m 6s	the patch passed
+1 💚	cc	9m 6s	the patch passed
-0 ⚠️	javac	9m 6s	root generated 2 new + 1885 unchanged - 2 fixed = 1887 total (was 1887)
+1 💚	checkstyle	2m 3s	root: The patch generated 0 new + 22 unchanged - 4 fixed = 22 total (was 26)
+1 💚	whitespace	0m 1s	The patch has no whitespace issues.
+1 💚	xml	0m 3s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	12m 7s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	hbaseprotoc	6m 23s	the patch passed
+1 💚	spotbugs	16m 38s	the patch passed
		_ Other Tests _
+1 💚	asflicense	1m 7s	The patch does not generate ASF License warnings.
		91m 51s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3543/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3543
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool xml
uname	Linux 7797daa2f1a0 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `f049301`
Default Java	AdoptOpenJDK-1.8.0_282-b08
javac	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3543/2/artifact/yetus-general-check/output/diff-compile-javac-root.txt
Max. process+thread count	141 (vs. ulimit of 12500)
modules	C: hbase-protocol-shaded hbase-common hbase-client hbase-server . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3543/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-07-30T08:26:21Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 37s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 19s	branch-2 passed
+1 💚	compile	3m 9s	branch-2 passed
+1 💚	shadedjars	7m 48s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	4m 55s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 21s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 21s	the patch passed
+1 💚	compile	3m 7s	the patch passed
+1 💚	javac	3m 7s	the patch passed
+1 💚	shadedjars	7m 43s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	4m 54s	the patch passed
		_ Other Tests _
+1 💚	unit	183m 33s	root in the patch passed.
		229m 44s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3543/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3543
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 60bed9e656fd 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `f049301`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3543/2/testReport/
Max. process+thread count	6538 (vs. ulimit of 12500)
modules	C: hbase-protocol-shaded hbase-common hbase-client hbase-server . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3543/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-07-30T10:24:52Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
-0 ⚠️	yetus	0m 7s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 26s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 39s	branch-2 passed
+1 💚	compile	2m 22s	branch-2 passed
+1 💚	shadedjars	6m 27s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 40s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 21s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 21s	the patch passed
+1 💚	compile	2m 18s	the patch passed
+1 💚	javac	2m 18s	the patch passed
+1 💚	shadedjars	6m 26s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 44s	the patch passed
		_ Other Tests _
-1 ❌	unit	311m 56s	root in the patch failed.
		348m 31s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3543/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#3543
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 487544cd80d2 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `f049301`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3543/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3543/2/testReport/
Max. process+thread count	4545 (vs. ulimit of 12500)
modules	C: hbase-protocol-shaded hbase-common hbase-client hbase-server . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3543/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

taklwu · 2021-07-30T18:26:31Z

that two failure tests TestVerifyReplicationCrossDiffHdfs (timeout) and TestReplicationEmptyWALRecovery are unrelated. it's passing locally

% mvn clean test -Dtest=TestVerifyReplicationCrossDiffHdfs
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.hbase.replication.TestVerifyReplicationCrossDiffHdfs
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 57.183 s - in org.apache.hadoop.hbase.replication.TestVerifyReplicationCrossDiffHdfs
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
[INFO] --- maven-surefire-plugin:3.0.0-M4:test (secondPartTestsExecution) @ hbase-mapreduce ---
[INFO] Tests are skipped.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:14 min
[INFO] Finished at: 2021-07-30T11:26:07-07:00
[INFO] ------------------------------------------------------------------------

% mvn clean test -Dtest=TestReplicationEmptyWALRecovery

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.hbase.replication.TestReplicationEmptyWALRecovery
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 44.277 s - in org.apache.hadoop.hbase.replication.TestReplicationEmptyWALRecovery
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
[INFO] --- maven-surefire-plugin:3.0.0-M4:test (secondPartTestsExecution) @ hbase-server ---
[INFO] Tests are skipped.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:26 min
[INFO] Finished at: 2021-07-30T11:24:14-07:00
[INFO] ------------------------------------------------------------------------

petersomogyi

Looks like a clean cherry-pick.

… call in rpc client" to branch-2 (#3543)" This reverts commit ca09643.

… call in rpc client" to branch-2 (apache#3543)" This reverts commit ca09643.

… call in rpc client" to branch-2 (#3543)" This reverts commit ca09643.

… rpc client" to branch-2 (#3543) 2/17 commits of HBASE-22120 Co-authored-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Peter Somogyi <psomogyi@apache.org>

HBASE-26125 Backport HBASE-25401 "Add trace support for async call in…

df580f6

… rpc client" to branch-2 2/17 commits of HBASE-22120

taklwu requested review from apurtell, Apache9 and petersomogyi July 29, 2021 22:45

taklwu requested review from wchevreuil and anoopsjohn July 30, 2021 18:26

petersomogyi approved these changes Aug 2, 2021

View reviewed changes

taklwu merged commit ca09643 into apache:branch-2 Aug 2, 2021

taklwu added a commit that referenced this pull request Aug 4, 2021

Revert "HBASE-26125 Backport HBASE-25401 "Add trace support for async…

d007b52

… call in rpc client" to branch-2 (#3543)" This reverts commit ca09643.

taklwu added a commit to taklwu/hbase that referenced this pull request Aug 4, 2021

Revert "HBASE-26125 Backport HBASE-25401 "Add trace support for async…

8a28556

… call in rpc client" to branch-2 (apache#3543)" This reverts commit ca09643.

taklwu mentioned this pull request Aug 4, 2021

Revert "HBASE-26125 Backport HBASE-25401 "Add trace support for async call in…" #3560

Closed

taklwu added a commit that referenced this pull request Aug 4, 2021

Revert "HBASE-26125 Backport HBASE-25401 "Add trace support for async…

fffdcba

… call in rpc client" to branch-2 (#3543)" This reverts commit ca09643.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-26125 Backport HBASE-25401 "Add trace support for async call in… #3543

HBASE-26125 Backport HBASE-25401 "Add trace support for async call in… #3543

taklwu commented Jul 29, 2021

Apache-HBase commented Jul 29, 2021

Apache-HBase commented Jul 30, 2021

Apache-HBase commented Jul 30, 2021

Apache-HBase commented Jul 30, 2021

Apache-HBase commented Jul 30, 2021

taklwu commented Jul 30, 2021

petersomogyi left a comment

HBASE-26125 Backport HBASE-25401 "Add trace support for async call in… #3543

HBASE-26125 Backport HBASE-25401 "Add trace support for async call in… #3543

Conversation

taklwu commented Jul 29, 2021

Apache-HBase commented Jul 29, 2021

Apache-HBase commented Jul 30, 2021

Apache-HBase commented Jul 30, 2021

Apache-HBase commented Jul 30, 2021

Apache-HBase commented Jul 30, 2021

taklwu commented Jul 30, 2021

petersomogyi left a comment

Choose a reason for hiding this comment