Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-22729 Start RSGroupInfoManager as default #405

Closed
wants to merge 4 commits into from
Closed

HBASE-22729 Start RSGroupInfoManager as default #405

wants to merge 4 commits into from

Conversation

infraio
Copy link
Contributor

@infraio infraio commented Jul 24, 2019

No description provided.

Apache9 and others added 4 commits July 23, 2019 09:44
Apache9
Apache9 requested changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@Apache9 Apache9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think starting RSGroupInfoManager by default should be done after HBASE-22695? As now we still need the coprocessor...

hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java
groupName = RSGroupInfo.DEFAULT_GROUP;
}
targetRSGInfo = rsGroupInfoManager.getRSGroup(groupName);
} catch (IOException exp) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the base branch is not right...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh. The reason is the method didn't throw IOException now. So remove the try...catch thing.

@infraio
Copy link
Contributor Author

infraio commented Jul 24, 2019

I think starting RSGroupInfoManager by default should be done after HBASE-22695? As no

What is the whole plan?

@Apache9
Copy link
Contributor

Apache9 commented Jul 24, 2019

https://github.com/Apache9/hbase/tree/HBASE-22695

I'm trying to store the rs group info to table first. It will lead to a huge change.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 62 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 3 new or modified test files.
_ HBASE-22514 Compile Tests _
+1 mvninstall 312 HBASE-22514 passed
+1 compile 71 HBASE-22514 passed
+1 checkstyle 89 HBASE-22514 passed
+1 shadedjars 364 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 43 HBASE-22514 passed
0 spotbugs 342 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 338 HBASE-22514 passed
_ Patch Compile Tests _
+1 mvninstall 348 the patch passed
+1 compile 71 the patch passed
+1 javac 71 the patch passed
+1 checkstyle 101 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 363 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 966 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 43 the patch passed
+1 findbugs 346 the patch passed
_ Other Tests _
-1 unit 14806 hbase-server in the patch failed.
+1 asflicense 31 The patch does not generate ASF License warnings.
18746
Reason Tests
Failed junit tests hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
Subsystem Report/Notes
Docker Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-405/1/artifact/out/Dockerfile
GITHUB PR #405
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux eddc57e48779 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-405/out/precommit/personality/provided.sh
git revision HBASE-22514 / 7a0b822
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-405/1/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-405/1/testReport/
Max. process+thread count 4576 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-405/1/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@infraio
Copy link
Contributor Author

infraio commented Jul 25, 2019

https://github.com/Apache9/hbase/tree/HBASE-22695

I'm trying to store the rs group info to table first. It will lead to a huge change.

Got it. Will continue this issue later.

@asfgit asfgit force-pushed the HBASE-22514 branch 3 times, most recently from 47d6533 to 1b5f6b5 Compare July 30, 2019 13:01
@asfgit asfgit force-pushed the HBASE-22514 branch 4 times, most recently from 77e95bd to e4b1720 Compare August 8, 2019 03:58
@asfgit asfgit force-pushed the HBASE-22514 branch 3 times, most recently from 32a2015 to 8660b52 Compare August 18, 2019 04:14
@asfgit asfgit force-pushed the HBASE-22514 branch 4 times, most recently from 4741f66 to 548e8c4 Compare August 27, 2019 12:35
@Apache9 Apache9 closed this Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Apache9 Apache9 Apache9 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@infraio @Apache9 @Apache-HBase