HBASE-26714 Introduce path configuration for system coprocessors #4069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taklwu
requested review from
gjacoby126,
ankitsinghal,
apurtell,
petersomogyi,
wchevreuil and
z-york
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
wchevreuil
reviewed
Jan 27, 2022
| hasPriorityOverride = true; | ||
| } | ||
| if (classNameToken.length == 3) { |
There was a problem hiding this comment.
Shouldn't we set overridePriority here as well? Or is it supposed to be ignored and use SYSTEM always? And what if the config definition is invalid, say CLASS_NAME|PATH? Should we perform some validation?
There was a problem hiding this comment.
I missed that and will fix , thanks for pointing that out
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
i need to check why |
wchevreuil
approved these changes
Jan 28, 2022
cbaenziger
reviewed
Jan 28, 2022
| cl = CoprocessorClassLoader.getClassLoader(path, this.getClass().getClassLoader(), | ||
| pathPrefix, conf); | ||
| } catch (IOException ioe) { | ||
| // if system coprocessors cannot be obtained, we also about the region server |
There was a problem hiding this comment.
I think this should read, we also abort
| pathPrefix, conf); | ||
| } catch (IOException ioe) { | ||
| // if system coprocessors cannot be obtained, we also about the region server | ||
| LOG.error("Cannot fetch external System coprocessor class {} with path {}", className, |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
In fact, I also learnt from the code that |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
ankitsinghal
approved these changes
Jan 29, 2022
hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorHost.java
Outdated
Show resolved
Hide resolved
hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorHost.java
Outdated
Show resolved
Hide resolved
Comment on lines
172
to
180
| if (hasPath) { | ||
| String pathPrefix = UUID.randomUUID().toString(); | ||
| try { | ||
| cl = CoprocessorClassLoader.getClassLoader(path, this.getClass().getClassLoader(), | ||
| pathPrefix, conf); | ||
| } catch (IOException ioe) { | ||
| // if system coprocessors cannot be obtained, we also about the region server | ||
| LOG.error("Cannot fetch external System coprocessor class {} with path {}", className, | ||
| path); | ||
| abortServer(className, ioe); |
There was a problem hiding this comment.
Can we move this logic under the original try{} catch{}, so that we don't have multiple condition for "abortServer(className, ioe);"
There was a problem hiding this comment.
I was trying to separate them and throws with different message, so, I think merging them may confuse operators and they won't know it was caused by loading system coprocessor remotely
There was a problem hiding this comment.
LOG.error("Cannot fetch external System coprocessor class {} with path {}", className, path);
The error message doesn't seem correct as the class will be fetched(or loaded) in the next step. And I also still believe that as the IOException should already be covering the reason if the path is incorrect, we should merge this try-catch with the other to avoid the redundant code.
There was a problem hiding this comment.
I agreed that the IOException will cover the right stacktrace, and just to clarify that CoprocessorClassLoader.getClassLoader internally will first check if the given path exist before actually loading the classname from the jar, that's why I split them into two blocks originally and want to tell the operators from logs that the jar file does not exist and it's not only about give coprocessor class does not exist
There was a problem hiding this comment.
c49b2c6 has merged the block into a single try-catch, and thanks for your explanation
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
Outdated
Show resolved
Hide resolved
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
Outdated
Show resolved
Hide resolved
|
squashed and trying to trigger the precommit tests |
|
🎊 +1 overall
This message was automatically generated. |
|
+1 and Thanks for taking care of the review comments. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
2 similar comments
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.