HBASE-26730 Extend hbase shell 'status' command to support an option 'tasks' #4094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apurtell
force-pushed
the
HBASE-26730-branch-2
branch
from
7b187aa
to
cfd925e
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
Unit test failures are not related. Looks like it is about time to do a unit test cleanup on branch-2. |
gjacoby126
reviewed
Feb 4, 2022
| serverMetricsMap = new HashMap<>(); | ||
| } | ||
| final Map<ServerName, ServerMetrics> map = serverMetricsMap; | ||
| serverManager.getOnlineServers().entrySet() |
There was a problem hiding this comment.
nit: could we factor out the common code into a helper rather than duplicating?
There was a problem hiding this comment.
I suppose it is possible to collapse this into a single code block, would that be better? E.g.
boolean doTasks = false;
....
case TASKS:
doTasks = true;
// fall through
case LIVE_SERVERS: {
...
// do stuff
if (doTasks) {
// do tasks stuff too, like the master monitoredtask collection
...
}
There was a problem hiding this comment.
I did take up your suggestion to D.R.Y this and was able to remove some lines, it looks good @gjacoby126
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
Outdated
Show resolved
Hide resolved
apurtell
force-pushed
the
HBASE-26730-branch-2
branch
from
cfd925e
to
86ee7b4
Compare
|
Rebased and addresses @gjacoby126 's feedback |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
virajjasani
approved these changes
Feb 15, 2022
|
As with the master PR will take care of the checkstyle issues before merge. |
…'tasks' Expose monitored tasks state in ClusterStatus API via new option in ServerLoad. Add shell support for interrogating monitored tasks state in ServerLoad.
…sks in 'tasks' view
apurtell
force-pushed
the
HBASE-26730-branch-2
branch
from
86ee7b4
to
716dad9
Compare
asfgit
pushed a commit
that referenced
this pull request
Feb 16, 2022
…'tasks' (#4094) Signed-off-by: Geoffrey Jacoby <gjacoby@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose monitored tasks state in ClusterStatus API via new option in ServerLoad.
Add shell support for interrogating monitored tasks state in ServerLoad.
Here's a prototype running on a branch-2 fork:
: