Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-26899 [branch-2.4] Run spotless:apply #4290

Closed
wants to merge 3 commits into from
Closed

HBASE-26899 [branch-2.4] Run spotless:apply #4290

wants to merge 3 commits into from

Conversation

apurtell
Copy link
Contributor

@apurtell apurtell commented Mar 28, 2022 •
edited
Loading

Backport HBASE-26617 to enable spotless on branch-2.4. Then run spotless:apply without a ratchet.

@Apache9 @apurtell
HBASE-26617 Use spotless to reduce the pain on fixing checkstyle issu…
1d4e835 
…es (apache#4214)

Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>

Conflicts:
	pom.xml
@Apache9 @apurtell
HBASE-26617 Addendum add removeUnusedImports
1b213ff 
Conflicts:
	pom.xml
@apurtell apurtell requested a review from Apache9 March 28, 2022 18:27
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 32s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 7s No case conflicting files found.
+0 🆗 shelldocs 0m 7s Shelldocs was not available.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2.4 Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for branch
+1 💚 mvninstall 2m 4s branch-2.4 passed
+1 💚 compile 5m 54s branch-2.4 passed
+1 💚 checkstyle 2m 19s branch-2.4 passed
+1 💚 spotbugs 18m 27s branch-2.4 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 1m 50s the patch passed
+1 💚 compile 5m 53s the patch passed
-0 ⚠️ javac 5m 53s root generated 38 new + 1638 unchanged - 38 fixed = 1676 total (was 1676)
-0 ⚠️ checkstyle 1m 48s root: The patch generated 752 new + 2006 unchanged - 2565 fixed = 2758 total (was 4571)
+1 💚 shellcheck 0m 0s There were no new shellcheck issues.
-0 ⚠️ whitespace 0m 0s The patch has 26 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚 xml 0m 29s The patch has no ill-formed XML file.
+1 💚 hadoopcheck 10m 11s Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2 3.2.1.
+1 💚 spotbugs 22m 18s the patch passed
_ Other Tests _
+1 💚 asflicense 5m 49s The patch does not generate ASF License warnings.
99m 31s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4290/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #4290
Optional Tests dupname asflicense shellcheck shelldocs javac hadoopcheck xml compile spotbugs hbaseanti checkstyle
uname Linux bf317bfb9313 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.4 / 9355506
Default Java AdoptOpenJDK-1.8.0_282-b08
javac https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4290/1/artifact/yetus-general-check/output/diff-compile-javac-root.txt
checkstyle https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4290/1/artifact/yetus-general-check/output/diff-checkstyle-root.txt
whitespace https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4290/1/artifact/yetus-general-check/output/whitespace-eol.txt
Max. process+thread count 138 (vs. ulimit of 12500)
modules C: hbase-checkstyle hbase-annotations hbase-build-configuration hbase-logging hbase-protocol-shaded hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-protocol hbase-client hbase-zookeeper hbase-replication hbase-resource-bundle hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-external-blockcache hbase-hbtop hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project hbase-archetypes/hbase-archetype-builder . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4290/1/console
versions git=2.17.1 maven=3.6.3 shellcheck=0.4.6 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 43s Docker mode activated.
-0 ⚠️ yetus 0m 26s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.4 Compile Tests _
+0 🆗 mvndep 0m 33s Maven dependency ordering for branch
+1 💚 mvninstall 4m 36s branch-2.4 passed
+1 💚 compile 3m 54s branch-2.4 passed
+1 💚 shadedjars 10m 22s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 25m 9s branch-2.4 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 35s Maven dependency ordering for patch
+1 💚 mvninstall 5m 46s the patch passed
+1 💚 compile 4m 28s the patch passed
+1 💚 javac 4m 28s the patch passed
+1 💚 shadedjars 9m 53s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 23m 13s the patch passed
_ Other Tests _
-1 ❌ unit 14m 24s root in the patch failed.
132m 54s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4290/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #4290
Optional Tests javac javadoc unit shadedjars compile
uname Linux de3a06a9bd76 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.4 / 9355506
Default Java AdoptOpenJDK-11.0.10+9
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4290/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4290/1/testReport/
Max. process+thread count 726 (vs. ulimit of 12500)
modules C: hbase-checkstyle hbase-annotations hbase-build-configuration hbase-logging hbase-protocol-shaded hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-protocol hbase-client hbase-zookeeper hbase-replication hbase-resource-bundle hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-external-blockcache hbase-hbtop hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project hbase-archetypes/hbase-archetype-builder . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4290/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 56s Docker mode activated.
-0 ⚠️ yetus 0m 22s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.4 Compile Tests _
+0 🆗 mvndep 0m 21s Maven dependency ordering for branch
+1 💚 mvninstall 2m 42s branch-2.4 passed
+1 💚 compile 1m 27s branch-2.4 passed
+1 💚 shadedjars 4m 15s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 8m 31s branch-2.4 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 1m 50s the patch passed
+1 💚 compile 1m 19s the patch passed
+1 💚 javac 1m 19s the patch passed
+1 💚 shadedjars 3m 50s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 8m 39s the patch passed
_ Other Tests _
-1 ❌ unit 265m 44s root in the patch failed.
313m 32s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4290/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #4290
Optional Tests javac javadoc unit shadedjars compile
uname Linux 7def600675cb 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.4 / 9355506
Default Java AdoptOpenJDK-1.8.0_282-b08
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4290/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4290/1/testReport/
Max. process+thread count 2726 (vs. ulimit of 12500)
modules C: hbase-checkstyle hbase-annotations hbase-build-configuration hbase-logging hbase-protocol-shaded hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-protocol hbase-client hbase-zookeeper hbase-replication hbase-resource-bundle hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-external-blockcache hbase-hbtop hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project hbase-archetypes/hbase-archetype-builder . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4290/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@apurtell
Copy link
Contributor Author

The precommit result is revealing some flaky test issues. This change includes only formatting changes.

@apurtell apurtell changed the title HBASE-26899 Run spotless:apply on branch-2s (and backport HBASE-26617) HBASE-26899 [branch-2.4] Run spotless:apply Mar 31, 2022
@apurtell
Copy link
Contributor Author

@Apache9 I didn't see 'ratchetFrom' in POM configuration before, but now I have removed it, and the changes are applied as one would expect for the first time here. I understand the intent of ratchetFrom is to gradually introduce changes but I think we want to do one shot application everywhere. I have updated the description accordingly and also added a PR for master branch where the 'ratchetFrom' is removed.

@apurtell
Copy link
Contributor Author

Work has been progressing on #4312 instead.

@apurtell apurtell closed this Apr 13, 2022
@apurtell apurtell deleted the HBASE-26899-branch-2.4 branch April 13, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Apache9 Apache9 Awaiting requested review from Apache9

@ndimiduk ndimiduk Awaiting requested review from ndimiduk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apurtell @Apache-HBase @Apache9