-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-11062 hbtop #438
HBASE-11062 hbtop #438
Conversation
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it better to put this module into hbase-operator-tools?
* Represents a filter that's filtering the metric {@link Record}s. | ||
*/ | ||
@InterfaceAudience.Private | ||
public final class Filter { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have a Filter
class in HBase so maybe add a special prefix here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, will change the class name.
Actually, I thought that was better. However, considering to backport this to branch-1 after committing it to branch-2+, I think it's better to put this into the hbase project because managing the compatibilities is much easier. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
I decided not to use Lanterna to remove the license problem. Closing this PR and will create a new PR after removing the license problem. |
This still has the license issue for Lanterna (https://github.com/mabe02/lanterna) but other than that it's ready for review.
For the details of the discussion for the license issue:
https://lists.apache.org/thread.html/7c6d5fc00d870d52253ce429aca1ef5f8f477fe2a8e384e3793e277e@%3Cdev.hbase.apache.org%3E
mabe02/lanterna#415
We can run hbtop by running
hbase top
command, and press 'h' key in the top screen for the help screen.For the details of hbtop, this is the presentation in NoSQL day 2019 (the name is changed from htop to hbtop):
https://dataworkssummit.com/nosql-day-2019/session/supporting-apache-hbase-troubleshooting-and-supportability-improvements/