HBASE-22880 Move the DirScanPool out and do not use static field #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reidddddd
reviewed
Aug 23, 2019
| // Start log cleaner thread | ||
| int cleanerInterval = conf.getInt("hbase.master.cleaner.interval", 600 * 1000); | ||
| this.logCleaner = new LogCleaner(cleanerInterval, this, conf, | ||
| getMasterFileSystem().getOldLogDir().getFileSystem(conf), getMasterFileSystem().getOldLogDir(), cleanerPool); |
Reidddddd
reviewed
Aug 23, 2019
| //start the hfile archive cleaner thread | ||
| Path archiveDir = HFileArchiveUtil.getArchivePath(conf); | ||
| Map<String, Object> params = new HashMap<String, Object>(); | ||
| params.put(MASTER, this); | ||
| this.hfileCleaner = new HFileCleaner(cleanerInterval, this, conf, getMasterFileSystem() | ||
| .getFileSystem(), archiveDir, params); | ||
| .getFileSystem(), archiveDir, cleanerPool, params); |
There was a problem hiding this comment.
nit, usually don't start with '.'
Reidddddd
reviewed
Aug 23, 2019
| FileSystem fs, Path oldFileDir, String confKey) { | ||
| this(name, sleepPeriod, s, conf, fs, oldFileDir, confKey, null); | ||
| FileSystem fs, Path oldFileDir, String confKey, DirScanPool pool) { | ||
| this(name, sleepPeriod, s, conf, fs, oldFileDir, confKey,pool, null); |
There was a problem hiding this comment.
nit, space between ,pool
Reidddddd
reviewed
Aug 23, 2019
| @Override | ||
| public synchronized void onConfigurationChange(Configuration conf) { | ||
| int newSize = CleanerChore.calculatePoolSize( | ||
| conf.get(CleanerChore.CHORE_POOL_SIZE, CleanerChore.DEFAULT_CHORE_POOL_SIZE)); |
Reidddddd
requested changes
Aug 23, 2019
Reidddddd
reviewed
Aug 23, 2019
| import org.apache.hadoop.conf.Configuration; | ||
| import org.apache.hadoop.hbase.classification.InterfaceAudience; | ||
| import org.apache.hadoop.hbase.conf.ConfigurationObserver; | ||
| import org.slf4j.Logger; |
There was a problem hiding this comment.
In branch-1, we use package org.apache.commons.logging
Reidddddd
reviewed
Aug 23, 2019
| * Checks if pool can be updated. If so, mark for update later. | ||
| * @param conf configuration | ||
| */ | ||
| @Override public synchronized void onConfigurationChange(Configuration conf) { |
There was a problem hiding this comment.
A new line after @Override
Reidddddd
reviewed
Aug 23, 2019
| import java.util.ArrayList; | ||
| import java.util.Collections; | ||
| import java.util.List; | ||
| import java.util.*; |
Reidddddd
requested changes
Aug 23, 2019
|
💔 -1 overall
This message was automatically generated. |
Reidddddd
reviewed
Aug 23, 2019
| /** | ||
| * The thread pool used for scan directories | ||
| */ | ||
| @InterfaceAudience.Private public class DirScanPool implements ConfigurationObserver { |
There was a problem hiding this comment.
A new line after @InterfaceAudience.Private
Reidddddd
reviewed
Aug 23, 2019
| public static void tearDown() { | ||
| POOL.shutdownNow(); | ||
| } | ||
|
|
There was a problem hiding this comment.
nit, just keep one empty line.
Reidddddd
approved these changes
Aug 23, 2019
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HBASE-22880