HBASE-28068 Add hbase.normalizer.merge.merge_request_max_number_of_re… #5429

rahulLiving · 2023-09-22T06:51:04Z

…gions property … (#5403)
Authored-by: Rahul Kumar rahul.kumar@rahulku-ltmdgmc.internal.salesforce.com
Signed-off-by: Nick Dimiduk ndimiduk@apache.org @rahulLiving

…gions property … (apache#5403) Authored-by: Rahul Kumar <rahul.kumar@rahulku-ltmdgmc.internal.salesforce.com> Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>

ndimiduk · 2023-09-22T11:38:46Z

...rver/src/test/java/org/apache/hadoop/hbase/master/normalizer/TestSimpleRegionNormalizer.java

+  @Test
+  public void testHonorsMergeRequestMaxNumberOfRegionsCount() {
+    conf.setBoolean(SPLIT_ENABLED_KEY, false);
+    conf.setInt(MERGE_MIN_REGION_COUNT_KEY, 1);


@rahulLiving this config doesn't exist on branch-2.4.

Apache-HBase · 2023-09-25T08:16:12Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2.4 Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 15s	branch-2.4 passed
+1 💚	compile	2m 46s	branch-2.4 passed
+1 💚	checkstyle	0m 47s	branch-2.4 passed
+1 💚	spotless	0m 39s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 57s	branch-2.4 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 16s	the patch passed
+1 💚	compile	2m 48s	the patch passed
+1 💚	javac	2m 48s	the patch passed
+1 💚	checkstyle	0m 48s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	15m 34s	Patch does not cause any errors with Hadoop 2.10.2 or 3.1.4 3.2.4 3.3.6.
+1 💚	spotless	0m 39s	patch has no errors when running spotless:check.
+1 💚	spotbugs	2m 12s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 18s	The patch does not generate ASF License warnings.
		35m 45s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5429/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5429
Optional Tests	dupname asflicense javac spotless xml spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 27be46d63b3e 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.4 / `e8aa715`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	80 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5429/2/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-09-25T10:48:57Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 15s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.4 Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 13s	branch-2.4 passed
+1 💚	compile	0m 58s	branch-2.4 passed
+1 💚	shadedjars	4m 17s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 39s	branch-2.4 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 18s	the patch passed
+1 💚	compile	0m 58s	the patch passed
+1 💚	javac	0m 58s	the patch passed
+1 💚	shadedjars	4m 12s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 38s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 30s	hbase-common in the patch passed.
+1 💚	unit	165m 43s	hbase-server in the patch passed.
		188m 23s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5429/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5429
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux b99005d06a15 5.4.0-153-generic #170-Ubuntu SMP Fri Jun 16 13:43:31 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.4 / `e8aa715`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5429/2/testReport/
Max. process+thread count	4374 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5429/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-09-25T10:50:23Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 44s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.4 Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 9s	branch-2.4 passed
+1 💚	compile	0m 45s	branch-2.4 passed
+1 💚	shadedjars	4m 10s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 34s	branch-2.4 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	1m 58s	the patch passed
+1 💚	compile	0m 44s	the patch passed
+1 💚	javac	0m 44s	the patch passed
+1 💚	shadedjars	4m 8s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 32s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 37s	hbase-common in the patch passed.
-1 ❌	unit	168m 4s	hbase-server in the patch failed.
		189m 52s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5429/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#5429
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 449d88b10646 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.4 / `e8aa715`
Default Java	Temurin-1.8.0_352-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5429/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5429/2/testReport/
Max. process+thread count	3746 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5429/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

rahulLiving and others added 2 commits September 22, 2023 12:15

HBASE-28068 Add hbase.normalizer.merge.merge_request_max_number_of_re…

387728b

…gions property … (apache#5403) Authored-by: Rahul Kumar <rahul.kumar@rahulku-ltmdgmc.internal.salesforce.com> Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>

revert unwanted change

5453476

This comment was marked as outdated.

Sign in to view

ndimiduk reviewed Sep 22, 2023

View reviewed changes

remove var

67f867e

ndimiduk merged commit c602eea into apache:branch-2.4 Sep 25, 2023
1 check failed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-28068 Add hbase.normalizer.merge.merge_request_max_number_of_re… #5429

HBASE-28068 Add hbase.normalizer.merge.merge_request_max_number_of_re… #5429

rahulLiving commented Sep 22, 2023

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

ndimiduk Sep 22, 2023

Apache-HBase commented Sep 25, 2023

Apache-HBase commented Sep 25, 2023

Apache-HBase commented Sep 25, 2023

HBASE-28068 Add hbase.normalizer.merge.merge_request_max_number_of_re… #5429

HBASE-28068 Add hbase.normalizer.merge.merge_request_max_number_of_re… #5429

Conversation

rahulLiving commented Sep 22, 2023

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

ndimiduk Sep 22, 2023

Choose a reason for hiding this comment

Apache-HBase commented Sep 25, 2023

Apache-HBase commented Sep 25, 2023

Apache-HBase commented Sep 25, 2023