-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-28180 Review the usage of RegionStates.getOrCreateServer #5486
Conversation
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
··· There are still some missing places where we fail to create the server state node. Let me dig more. |
Ah the log is too big so it has been truncated... Let me see if I can reproduce the problem locally... |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
OK, we can see that
The target region server is already dead, as it has a SCP for it. And in the above log, the SCP finishes before we want to persist the location to hbase:meta in regionOpening(because 021d69fb7740,44905,1699038567953 is the one which holds hbase:meta...), and finally lead to the NPE... Let me think how to fix this. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
The failed UT seems related. Let me check. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
Let me check what is the root cause. |
For rollback SCP, the error is
Let me dig more on why this could happen. |
OK, it happens while we are restarting the assignment manager, where the server state nodes have not been intialized yet... Let me think how we can fix this, it could cause bunch of procedure related tests to be flaky... |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
I think the failure is introduced by HBASE-28199, where we may will add procedure back in a thread other than PEWorker. Let me think how to fix this... |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
OK, good, finally all green! |
Signed-off-by: Xiaolin Ha <haxiaolin@apache.org> (cherry picked from commit e45b9c4)
Signed-off-by: Xiaolin Ha <haxiaolin@apache.org> (cherry picked from commit e45b9c4)
Signed-off-by: Xiaolin Ha <haxiaolin@apache.org> (cherry picked from commit e45b9c4)
…e#5486) Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
No description provided.