-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport "HBASE-27814 Add support for dump and process metrics servlet in REST InfoServer" to branch-2.6 #5729
Conversation
Backports #5215. Sorry for the mess-up in previous PR. |
Built code locally, extracted assembly, started a local cluster and started HBase REST server.
|
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
Do we not have this kind of basic functional test in the suite? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
FYI, I don't usually request review of backport PRs, unless there's something particularly tricky/different between the master and backport changes. In this case, the diffs look basically identical (by my scan), so I would just make the PR to verify the build-bot is happy and move on.
I suppose we do but that must run inside minicluster. I run this by pointing to a node (local/distributed).
Ah seems I am being extra cautious. Let me follow this approach going forward.
They are exactly same here. Thanks for you review. I will merge this then. |
Other changes: