Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-28714 Hadoop check for hadoop 3.4.0 is failing #6063

Merged
merged 1 commit into from
Jul 10, 2024
Merged

HBASE-28714 Hadoop check for hadoop 3.4.0 is failing #6063

merged 1 commit into from
Jul 10, 2024

Conversation

Apache9
Copy link
Contributor

@Apache9 Apache9 commented Jul 9, 2024

No description provided.

@Apache9 Apache9 self-assigned this Jul 9, 2024
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 48s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for branch
+1 💚 mvninstall 2m 54s master passed
+1 💚 compile 7m 48s master passed
+1 💚 checkstyle 1m 7s master passed
+1 💚 spotbugs 9m 29s master passed
+1 💚 spotless 0m 44s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
+1 💚 mvninstall 2m 51s the patch passed
+1 💚 compile 7m 45s the patch passed
+1 💚 javac 7m 45s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 1m 7s the patch passed
+1 💚 xmllint 0m 1s No new issues.
+1 💚 spotbugs 9m 56s the patch passed
+1 💚 hadoopcheck 10m 18s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚 spotless 0m 43s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 32s The patch does not generate ASF License warnings.
63m 27s
Subsystem Report/Notes
Docker ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6063/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #6063
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless xmllint
uname Linux 897480cc5674 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / df47edd
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 190 (vs. ulimit of 30000)
modules C: hbase-asyncfs hbase-server . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6063/1/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache9
Copy link
Contributor Author

Apache9 commented Jul 9, 2024

OK, good. Hadoop check passed.

@Apache9 Apache9 requested a review from ndimiduk July 9, 2024 12:46
@Apache9
Copy link
Contributor Author

Apache9 commented Jul 9, 2024

@ndimiduk FYI.

ndimiduk
ndimiduk approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@ndimiduk ndimiduk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one question though...

pom.xml
@@ -3937,6 +3937,10 @@
<groupId>org.slf4j</groupId>
<artifactId>slf4j-reload4j</artifactId>
</exclusion>
<exclusion>
<groupId>org.bouncycastle</groupId>
<artifactId>bcprov-jdk15on</artifactId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So there isn't actually a runtime dependency on this jar?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is introduced by HDFS-15098, for adding SM4 encryption support. We need further tests to see if we need to introduce the dependency manually in HBase. For now we only depend on bouncycastle related jars in test scope in HBase.

For now I think just exclude it is fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried locally, seems there are still problem while actually running tests against 3.4.0.

Anyway, let's get this in to at least make compilation pass for 3.4.0, and then open another issue for addressing the test issues.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 26s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for branch
+1 💚 mvninstall 3m 8s master passed
+1 💚 compile 2m 5s master passed
+1 💚 javadoc 2m 27s master passed
+1 💚 shadedjars 5m 46s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 3m 0s the patch passed
+1 💚 compile 2m 5s the patch passed
+1 💚 javac 2m 5s the patch passed
+1 💚 javadoc 2m 29s the patch passed
+1 💚 shadedjars 5m 40s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌ unit 232m 32s /patch-unit-root.txt root in the patch failed.
266m 1s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6063/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #6063
Optional Tests javac javadoc unit compile shadedjars
uname Linux fdb3ba6c987e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / df47edd
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6063/1/testReport/
Max. process+thread count 6315 (vs. ulimit of 30000)
modules C: hbase-asyncfs hbase-server . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6063/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache9 Apache9 merged commit b70bd11 into apache:master Jul 10, 2024
1 check failed
Apache9 added a commit that referenced this pull request Jul 10, 2024
@Apache9
HBASE-28714 Hadoop check for hadoop 3.4.0 is failing (#6063)
3bf1f21 
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
(cherry picked from commit b70bd11)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndimiduk ndimiduk ndimiduk approved these changes

Assignees

@Apache9 Apache9

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Apache9 @Apache-HBase @ndimiduk