-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-28774: Protect hbase:meta from any hotspotting regions by balancing them to different region servers #6173
base: master
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
b756ee1
to
a3d4d0a
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
||
Map<ServerName, List<RegionInfo>> clusterState = this.cluster.clusterState; | ||
|
||
for (Map.Entry<ServerName, List<RegionInfo>> entry : clusterState.entrySet()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let us add comment about what we are doing and how it would impact the balancer decision with an example.
a3d4d0a
to
e05d406
Compare
e05d406
to
e0ac33a
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
* on same RS | ||
*/ | ||
@InterfaceAudience.Private public class MutuallyExclusiveTablesCostFunction extends CostFunction { | ||
public static final String MUTUALLY_EXCLUSIVE_TABLES_KEY = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: good to add comments for config.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
HBASE-28774
The idea is to provide a configuration where by one can configure mutually exclusive tables. For example: hbase:meta,SYSTEM.CATALOG can be mutually exclusive tables. Anytime these 2 tables come together the new plan will be costly and would need a rebalancing.