Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-23044 CatalogJanitor#cleanMergeQualifier may clean wrong parent… #637

Merged
merged 1 commit into from
Sep 19, 2019

Conversation

infraio
Copy link
Contributor

@infraio infraio commented Sep 18, 2019

… regions

Copy link
Contributor

@Apache9 Apache9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The getMergeRegionsRaw method is a bit overkill which uses a regex as the meta row is small...

Glad to see we can just remove it.

+1.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
💙 reexec 0m 33s Docker mode activated.
_ Prechecks _
💚 dupname 0m 0s No case conflicting files found.
💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
💚 @author 0m 0s The patch does not contain any @author tags.
💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ master Compile Tests _
💙 mvndep 0m 33s Maven dependency ordering for branch
💚 mvninstall 5m 37s master passed
💚 compile 1m 21s master passed
💚 checkstyle 2m 1s master passed
💚 shadedjars 4m 53s branch has no errors when building our shaded downstream artifacts.
💚 javadoc 0m 57s master passed
💙 spotbugs 4m 32s Used deprecated FindBugs config; considering switching to SpotBugs.
💚 findbugs 5m 38s master passed
_ Patch Compile Tests _
💙 mvndep 0m 13s Maven dependency ordering for patch
💚 mvninstall 5m 23s the patch passed
💚 compile 1m 22s the patch passed
💚 javac 1m 22s the patch passed
💔 checkstyle 0m 33s hbase-client: The patch generated 2 new + 46 unchanged - 0 fixed = 48 total (was 46)
💚 whitespace 0m 0s The patch has no whitespace issues.
💚 shadedjars 4m 56s patch has no errors when building our shaded downstream artifacts.
💚 hadoopcheck 17m 38s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚 javadoc 0m 58s the patch passed
💚 findbugs 5m 57s the patch passed
_ Other Tests _
💚 unit 1m 57s hbase-client in the patch passed.
💚 unit 165m 11s hbase-server in the patch passed.
💚 asflicense 0m 46s The patch does not generate ASF License warnings.
235m 8s
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-637/1/artifact/out/Dockerfile
GITHUB PR #637
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 0411e3f2ad8c 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-637/out/precommit/personality/provided.sh
git revision master / cb62f73
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-637/1/artifact/out/diff-checkstyle-hbase-client.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-637/1/testReport/
Max. process+thread count 4548 (vs. ulimit of 10000)
modules C: hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-637/1/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@infraio
Copy link
Contributor Author

infraio commented Sep 19, 2019

Fixed the checkstyle warning.

@infraio infraio merged commit 20bfb43 into apache:master Sep 19, 2019
asfgit pushed a commit that referenced this pull request Sep 19, 2019
… regions (#637)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
asfgit pushed a commit that referenced this pull request Sep 19, 2019
… regions (#637)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
asfgit pushed a commit that referenced this pull request Sep 19, 2019
… regions (#637)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
infraio added a commit to infraio/hbase that referenced this pull request Aug 17, 2020
… regions (apache#637)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
symat pushed a commit to symat/hbase that referenced this pull request Feb 17, 2021
… regions (apache#637)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit bded5a4)

Change-Id: I3b5a829bea3add9aaf634c9e1b5c68d2bd16e045
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants