Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-26722: HiveFilterSetOpTransposeRule incorrectly prunes UNION ALL… #3748

Conversation

asolimando
Copy link
Member

@asolimando asolimando commented Nov 10, 2022

… operands

What changes were proposed in this pull request?

Changing the way RexSimplify is invoked in HiveFilterSetOpTransposeRule to make it conform the way it’s always used in Calcite when you have inferred predicates: here they are doing a big conjunction of all inferred predicates plus the pushed-down one, instead of passing the inferred predicates as a parameter of RexSimplify::simplify.

Why are the changes needed?

Correctness

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing tests plus added the following qtest mvn test -Dtest=TestMiniLlapLocalCliDriver -Dqfile="union_all_filter_transpose.q" -Dtest.output.overwrite -pl itests/qtest -Pitests

@simhadri-g
Copy link
Member

simhadri-g commented Nov 17, 2022

LGTM

Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Nov 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ayushtkn ayushtkn merged commit 310cdd8 into apache:master Nov 17, 2022
@asolimando asolimando deleted the master-HIVE-26722-HiveFilterSetOpTransposeRule_pruning branch November 29, 2022 15:09
dengzhhu653 pushed a commit to dengzhhu653/hive that referenced this pull request Dec 15, 2022
… operands. (apache#3748). (Alessandro Solimando, reviewed by Ayush Saxena, Simhadri Govindappa)
DongWei-4 pushed a commit to DongWei-4/hive that referenced this pull request Dec 29, 2022
… operands. (apache#3748). (Alessandro Solimando, reviewed by Ayush Saxena, Simhadri Govindappa)

(cherry picked from commit 310cdd8)
InvisibleProgrammer pushed a commit to InvisibleProgrammer/hive that referenced this pull request Jul 13, 2023
Comment out classes to work on to be able to build the module

Refator TestCopyUtils.java

Before refactor: TestReplDumpTask

Refactor TestReplDumpTask.java

Before refactor: TestAtlasLoadTask

Refactor TestAtlasLoadTask.java

Refator TestRangerDumpTask.java

Before refactor: TestCompactionHeartbeatService

Refactor TestCompactionHeartbeatService.java

Before refactor: TestRetryable

Refactor TestRetryable.java

Before refactor: TestRangerLoadTask

Refactor: RangerLoadTask

Before refactor: TestAtlasDumpTask

Refactor: AtlasDumpTask

Before refactor: TestPrimaryToReplicaResourceFunction

Refactor TestPrimaryToReplicaResourceFunction

Before refactor: TestExportService

Refactor: TestExportService

HIVE-26522: Added test for HIVE-22033 regarding delegation token renewal (apache#3585)

HIVE-26676: Count distinct in subquery returning wrong results (Steve Carlin, reviewed by Alessandro Solimando, Aman Sinha, Krisztian Kasa)

HIVE-26736: Authorization failure for nested Views having WITH clause. (apache#3760). (Ayush Saxena, reviewed by Denys Kuzmenko)

HIVE-26628: Iceberg table is created when running explain ctas command (Krisztian Kasa, reviewed by Denys Kuzmenko)

HIVE-26734: Iceberg: Add an option to allow positional delete files without actual row data. (apache#3758). (Ayush Saxena, reviewed by Adam Szita, Denys Kuzmenko)

HIVE-26524: Use Calcite to remove sections of a query plan known never produces rows - ADDENDUM (Krisztian Kasa, reviewed by Stamatis Zampetakis)

HIVE-26740: HS2 makes direct connections to HMS backend DB due to Compaction/StatsUpdater (apache#3765) (Adam Szita, reviewed by Zhihua Deng)

HIVE-26631: Remove unused Thrift config parameters login.timeout and exponential.backoff.slot.length (xiuzhu9527 reviewed by Stamatis Zampetakis)

Closes apache#3672

HIVE-26747: Remove implementor from HiveRelNode (Krisztian Kasa, reviewed by Stamatis Zampetakis)

HIVE-26747: Remove implementor from HiveRelNode (Krisztian Kasa, reviewed by Stamatis Zampetakis) ADDENDUM

HIVE-26745: HPL unable to handle Decimal or null values in hplsql mode (apache#3769) (Adam Szita, reviewed by Attila Magyar and Denys Kuzmenko)

HIVE-26722: HiveFilterSetOpTransposeRule incorrectly prunes UNION ALL operands.  (apache#3748). (Alessandro Solimando, reviewed by Ayush Saxena, Simhadri Govindappa)

HIVE-26746: Request tracking: change to X-Request-ID header (apache#3770) (Laszlo Bodor reviewed by Zhihua Deng)

HIVE-26624: Set repl.background.enable on target after failover completion (Vinit Patni, reviewed by László Pintér, Teddy Choi)

Co-authored-by: vpatni <vpatni@cloudera.com>

HIVE-26712: HCatMapReduceTest writes test files in project base directory instead of build directory. (apache#3738) (Chris Nauroth reviewed by Ayush Saxena)

HIVE-26726: Tinyint column with windowing fn crashes at runtime (Steve Carlin, reviewed by Aman Sinha, Krisztian Kasa)

HIVE-26680: Make CMV use Direct Insert Semantics (Sourabh Badhya, reviewed by Denys Kuzmenko, Laszlo Vegh)

Closes apache#3715

HIVE-26243: Add vectorized implementation of the 'ds_kll_sketch' UDAF (Alessandro Solimando, reviewed by Denys Kuzmenko, Zoltan Haindrich)

Closes apache#3317

HIVE-26761: Add result sorting to complex_alias.q (apache#3783) (Balazs Cseh reviewed by Laszlo Bodor)

HIVE-26759: Update SHOW COMPACTIONS query to support Postgres HMS (Akshat Mathur, reviewed by Denys Kuzmenko, Zsolt Miskolczi)

Closes 3782

HIVE-26765: Hive Ranger URL policy for insert overwrite directory denies access when fully qualified paths are passed (apache#3790) (Simhadri Govindappa, reviewed by Adam Szita)

Small refactors

Fix bug
InvisibleProgrammer pushed a commit to InvisibleProgrammer/hive that referenced this pull request Jul 13, 2023
Comment out classes to work on to be able to build the module

Refator TestCopyUtils.java

Before refactor: TestReplDumpTask

Refactor TestReplDumpTask.java

Before refactor: TestAtlasLoadTask

Refactor TestAtlasLoadTask.java

Refator TestRangerDumpTask.java

Before refactor: TestCompactionHeartbeatService

Refactor TestCompactionHeartbeatService.java

Before refactor: TestRetryable

Refactor TestRetryable.java

Before refactor: TestRangerLoadTask

Refactor: RangerLoadTask

Before refactor: TestAtlasDumpTask

Refactor: AtlasDumpTask

Before refactor: TestPrimaryToReplicaResourceFunction

Refactor TestPrimaryToReplicaResourceFunction

Before refactor: TestExportService

Refactor: TestExportService

HIVE-26522: Added test for HIVE-22033 regarding delegation token renewal (apache#3585)

HIVE-26676: Count distinct in subquery returning wrong results (Steve Carlin, reviewed by Alessandro Solimando, Aman Sinha, Krisztian Kasa)

HIVE-26736: Authorization failure for nested Views having WITH clause. (apache#3760). (Ayush Saxena, reviewed by Denys Kuzmenko)

HIVE-26628: Iceberg table is created when running explain ctas command (Krisztian Kasa, reviewed by Denys Kuzmenko)

HIVE-26734: Iceberg: Add an option to allow positional delete files without actual row data. (apache#3758). (Ayush Saxena, reviewed by Adam Szita, Denys Kuzmenko)

HIVE-26524: Use Calcite to remove sections of a query plan known never produces rows - ADDENDUM (Krisztian Kasa, reviewed by Stamatis Zampetakis)

HIVE-26740: HS2 makes direct connections to HMS backend DB due to Compaction/StatsUpdater (apache#3765) (Adam Szita, reviewed by Zhihua Deng)

HIVE-26631: Remove unused Thrift config parameters login.timeout and exponential.backoff.slot.length (xiuzhu9527 reviewed by Stamatis Zampetakis)

Closes apache#3672

HIVE-26747: Remove implementor from HiveRelNode (Krisztian Kasa, reviewed by Stamatis Zampetakis)

HIVE-26747: Remove implementor from HiveRelNode (Krisztian Kasa, reviewed by Stamatis Zampetakis) ADDENDUM

HIVE-26745: HPL unable to handle Decimal or null values in hplsql mode (apache#3769) (Adam Szita, reviewed by Attila Magyar and Denys Kuzmenko)

HIVE-26722: HiveFilterSetOpTransposeRule incorrectly prunes UNION ALL operands.  (apache#3748). (Alessandro Solimando, reviewed by Ayush Saxena, Simhadri Govindappa)

HIVE-26746: Request tracking: change to X-Request-ID header (apache#3770) (Laszlo Bodor reviewed by Zhihua Deng)

HIVE-26624: Set repl.background.enable on target after failover completion (Vinit Patni, reviewed by László Pintér, Teddy Choi)

Co-authored-by: vpatni <vpatni@cloudera.com>

HIVE-26712: HCatMapReduceTest writes test files in project base directory instead of build directory. (apache#3738) (Chris Nauroth reviewed by Ayush Saxena)

HIVE-26726: Tinyint column with windowing fn crashes at runtime (Steve Carlin, reviewed by Aman Sinha, Krisztian Kasa)

HIVE-26680: Make CMV use Direct Insert Semantics (Sourabh Badhya, reviewed by Denys Kuzmenko, Laszlo Vegh)

Closes apache#3715

HIVE-26243: Add vectorized implementation of the 'ds_kll_sketch' UDAF (Alessandro Solimando, reviewed by Denys Kuzmenko, Zoltan Haindrich)

Closes apache#3317

HIVE-26761: Add result sorting to complex_alias.q (apache#3783) (Balazs Cseh reviewed by Laszlo Bodor)

HIVE-26759: Update SHOW COMPACTIONS query to support Postgres HMS (Akshat Mathur, reviewed by Denys Kuzmenko, Zsolt Miskolczi)

Closes 3782

HIVE-26765: Hive Ranger URL policy for insert overwrite directory denies access when fully qualified paths are passed (apache#3790) (Simhadri Govindappa, reviewed by Adam Szita)

Small refactors

Fix bug
InvisibleProgrammer pushed a commit to InvisibleProgrammer/hive that referenced this pull request Jul 14, 2023
Comment out classes to work on to be able to build the module

Refator TestCopyUtils.java

Before refactor: TestReplDumpTask

Refactor TestReplDumpTask.java

Before refactor: TestAtlasLoadTask

Refactor TestAtlasLoadTask.java

Refator TestRangerDumpTask.java

Before refactor: TestCompactionHeartbeatService

Refactor TestCompactionHeartbeatService.java

Before refactor: TestRetryable

Refactor TestRetryable.java

Before refactor: TestRangerLoadTask

Refactor: RangerLoadTask

Before refactor: TestAtlasDumpTask

Refactor: AtlasDumpTask

Before refactor: TestPrimaryToReplicaResourceFunction

Refactor TestPrimaryToReplicaResourceFunction

Before refactor: TestExportService

Refactor: TestExportService

HIVE-26522: Added test for HIVE-22033 regarding delegation token renewal (apache#3585)

HIVE-26676: Count distinct in subquery returning wrong results (Steve Carlin, reviewed by Alessandro Solimando, Aman Sinha, Krisztian Kasa)

HIVE-26736: Authorization failure for nested Views having WITH clause. (apache#3760). (Ayush Saxena, reviewed by Denys Kuzmenko)

HIVE-26628: Iceberg table is created when running explain ctas command (Krisztian Kasa, reviewed by Denys Kuzmenko)

HIVE-26734: Iceberg: Add an option to allow positional delete files without actual row data. (apache#3758). (Ayush Saxena, reviewed by Adam Szita, Denys Kuzmenko)

HIVE-26524: Use Calcite to remove sections of a query plan known never produces rows - ADDENDUM (Krisztian Kasa, reviewed by Stamatis Zampetakis)

HIVE-26740: HS2 makes direct connections to HMS backend DB due to Compaction/StatsUpdater (apache#3765) (Adam Szita, reviewed by Zhihua Deng)

HIVE-26631: Remove unused Thrift config parameters login.timeout and exponential.backoff.slot.length (xiuzhu9527 reviewed by Stamatis Zampetakis)

Closes apache#3672

HIVE-26747: Remove implementor from HiveRelNode (Krisztian Kasa, reviewed by Stamatis Zampetakis)

HIVE-26747: Remove implementor from HiveRelNode (Krisztian Kasa, reviewed by Stamatis Zampetakis) ADDENDUM

HIVE-26745: HPL unable to handle Decimal or null values in hplsql mode (apache#3769) (Adam Szita, reviewed by Attila Magyar and Denys Kuzmenko)

HIVE-26722: HiveFilterSetOpTransposeRule incorrectly prunes UNION ALL operands.  (apache#3748). (Alessandro Solimando, reviewed by Ayush Saxena, Simhadri Govindappa)

HIVE-26746: Request tracking: change to X-Request-ID header (apache#3770) (Laszlo Bodor reviewed by Zhihua Deng)

HIVE-26624: Set repl.background.enable on target after failover completion (Vinit Patni, reviewed by László Pintér, Teddy Choi)

Co-authored-by: vpatni <vpatni@cloudera.com>

HIVE-26712: HCatMapReduceTest writes test files in project base directory instead of build directory. (apache#3738) (Chris Nauroth reviewed by Ayush Saxena)

HIVE-26726: Tinyint column with windowing fn crashes at runtime (Steve Carlin, reviewed by Aman Sinha, Krisztian Kasa)

HIVE-26680: Make CMV use Direct Insert Semantics (Sourabh Badhya, reviewed by Denys Kuzmenko, Laszlo Vegh)

Closes apache#3715

HIVE-26243: Add vectorized implementation of the 'ds_kll_sketch' UDAF (Alessandro Solimando, reviewed by Denys Kuzmenko, Zoltan Haindrich)

Closes apache#3317

HIVE-26761: Add result sorting to complex_alias.q (apache#3783) (Balazs Cseh reviewed by Laszlo Bodor)

HIVE-26759: Update SHOW COMPACTIONS query to support Postgres HMS (Akshat Mathur, reviewed by Denys Kuzmenko, Zsolt Miskolczi)

Closes 3782

HIVE-26765: Hive Ranger URL policy for insert overwrite directory denies access when fully qualified paths are passed (apache#3790) (Simhadri Govindappa, reviewed by Adam Szita)

Small refactors

Fix bug
InvisibleProgrammer pushed a commit to InvisibleProgrammer/hive that referenced this pull request Jul 19, 2023
Comment out classes to work on to be able to build the module

Refator TestCopyUtils.java

Before refactor: TestReplDumpTask

Refactor TestReplDumpTask.java

Before refactor: TestAtlasLoadTask

Refactor TestAtlasLoadTask.java

Refator TestRangerDumpTask.java

Before refactor: TestCompactionHeartbeatService

Refactor TestCompactionHeartbeatService.java

Before refactor: TestRetryable

Refactor TestRetryable.java

Before refactor: TestRangerLoadTask

Refactor: RangerLoadTask

Before refactor: TestAtlasDumpTask

Refactor: AtlasDumpTask

Before refactor: TestPrimaryToReplicaResourceFunction

Refactor TestPrimaryToReplicaResourceFunction

Before refactor: TestExportService

Refactor: TestExportService

HIVE-26522: Added test for HIVE-22033 regarding delegation token renewal (apache#3585)

HIVE-26676: Count distinct in subquery returning wrong results (Steve Carlin, reviewed by Alessandro Solimando, Aman Sinha, Krisztian Kasa)

HIVE-26736: Authorization failure for nested Views having WITH clause. (apache#3760). (Ayush Saxena, reviewed by Denys Kuzmenko)

HIVE-26628: Iceberg table is created when running explain ctas command (Krisztian Kasa, reviewed by Denys Kuzmenko)

HIVE-26734: Iceberg: Add an option to allow positional delete files without actual row data. (apache#3758). (Ayush Saxena, reviewed by Adam Szita, Denys Kuzmenko)

HIVE-26524: Use Calcite to remove sections of a query plan known never produces rows - ADDENDUM (Krisztian Kasa, reviewed by Stamatis Zampetakis)

HIVE-26740: HS2 makes direct connections to HMS backend DB due to Compaction/StatsUpdater (apache#3765) (Adam Szita, reviewed by Zhihua Deng)

HIVE-26631: Remove unused Thrift config parameters login.timeout and exponential.backoff.slot.length (xiuzhu9527 reviewed by Stamatis Zampetakis)

Closes apache#3672

HIVE-26747: Remove implementor from HiveRelNode (Krisztian Kasa, reviewed by Stamatis Zampetakis)

HIVE-26747: Remove implementor from HiveRelNode (Krisztian Kasa, reviewed by Stamatis Zampetakis) ADDENDUM

HIVE-26745: HPL unable to handle Decimal or null values in hplsql mode (apache#3769) (Adam Szita, reviewed by Attila Magyar and Denys Kuzmenko)

HIVE-26722: HiveFilterSetOpTransposeRule incorrectly prunes UNION ALL operands.  (apache#3748). (Alessandro Solimando, reviewed by Ayush Saxena, Simhadri Govindappa)

HIVE-26746: Request tracking: change to X-Request-ID header (apache#3770) (Laszlo Bodor reviewed by Zhihua Deng)

HIVE-26624: Set repl.background.enable on target after failover completion (Vinit Patni, reviewed by László Pintér, Teddy Choi)

Co-authored-by: vpatni <vpatni@cloudera.com>

HIVE-26712: HCatMapReduceTest writes test files in project base directory instead of build directory. (apache#3738) (Chris Nauroth reviewed by Ayush Saxena)

HIVE-26726: Tinyint column with windowing fn crashes at runtime (Steve Carlin, reviewed by Aman Sinha, Krisztian Kasa)

HIVE-26680: Make CMV use Direct Insert Semantics (Sourabh Badhya, reviewed by Denys Kuzmenko, Laszlo Vegh)

Closes apache#3715

HIVE-26243: Add vectorized implementation of the 'ds_kll_sketch' UDAF (Alessandro Solimando, reviewed by Denys Kuzmenko, Zoltan Haindrich)

Closes apache#3317

HIVE-26761: Add result sorting to complex_alias.q (apache#3783) (Balazs Cseh reviewed by Laszlo Bodor)

HIVE-26759: Update SHOW COMPACTIONS query to support Postgres HMS (Akshat Mathur, reviewed by Denys Kuzmenko, Zsolt Miskolczi)

Closes 3782

HIVE-26765: Hive Ranger URL policy for insert overwrite directory denies access when fully qualified paths are passed (apache#3790) (Simhadri Govindappa, reviewed by Adam Szita)

Small refactors

Fix bug
yeahyung pushed a commit to yeahyung/hive that referenced this pull request Jul 20, 2023
… operands. (apache#3748). (Alessandro Solimando, reviewed by Ayush Saxena, Simhadri Govindappa)
InvisibleProgrammer pushed a commit to InvisibleProgrammer/hive that referenced this pull request Aug 7, 2023
Comment out classes to work on to be able to build the module

Refator TestCopyUtils.java

Before refactor: TestReplDumpTask

Refactor TestReplDumpTask.java

Before refactor: TestAtlasLoadTask

Refactor TestAtlasLoadTask.java

Refator TestRangerDumpTask.java

Before refactor: TestCompactionHeartbeatService

Refactor TestCompactionHeartbeatService.java

Before refactor: TestRetryable

Refactor TestRetryable.java

Before refactor: TestRangerLoadTask

Refactor: RangerLoadTask

Before refactor: TestAtlasDumpTask

Refactor: AtlasDumpTask

Before refactor: TestPrimaryToReplicaResourceFunction

Refactor TestPrimaryToReplicaResourceFunction

Before refactor: TestExportService

Refactor: TestExportService

HIVE-26522: Added test for HIVE-22033 regarding delegation token renewal (apache#3585)

HIVE-26676: Count distinct in subquery returning wrong results (Steve Carlin, reviewed by Alessandro Solimando, Aman Sinha, Krisztian Kasa)

HIVE-26736: Authorization failure for nested Views having WITH clause. (apache#3760). (Ayush Saxena, reviewed by Denys Kuzmenko)

HIVE-26628: Iceberg table is created when running explain ctas command (Krisztian Kasa, reviewed by Denys Kuzmenko)

HIVE-26734: Iceberg: Add an option to allow positional delete files without actual row data. (apache#3758). (Ayush Saxena, reviewed by Adam Szita, Denys Kuzmenko)

HIVE-26524: Use Calcite to remove sections of a query plan known never produces rows - ADDENDUM (Krisztian Kasa, reviewed by Stamatis Zampetakis)

HIVE-26740: HS2 makes direct connections to HMS backend DB due to Compaction/StatsUpdater (apache#3765) (Adam Szita, reviewed by Zhihua Deng)

HIVE-26631: Remove unused Thrift config parameters login.timeout and exponential.backoff.slot.length (xiuzhu9527 reviewed by Stamatis Zampetakis)

Closes apache#3672

HIVE-26747: Remove implementor from HiveRelNode (Krisztian Kasa, reviewed by Stamatis Zampetakis)

HIVE-26747: Remove implementor from HiveRelNode (Krisztian Kasa, reviewed by Stamatis Zampetakis) ADDENDUM

HIVE-26745: HPL unable to handle Decimal or null values in hplsql mode (apache#3769) (Adam Szita, reviewed by Attila Magyar and Denys Kuzmenko)

HIVE-26722: HiveFilterSetOpTransposeRule incorrectly prunes UNION ALL operands.  (apache#3748). (Alessandro Solimando, reviewed by Ayush Saxena, Simhadri Govindappa)

HIVE-26746: Request tracking: change to X-Request-ID header (apache#3770) (Laszlo Bodor reviewed by Zhihua Deng)

HIVE-26624: Set repl.background.enable on target after failover completion (Vinit Patni, reviewed by László Pintér, Teddy Choi)

Co-authored-by: vpatni <vpatni@cloudera.com>

HIVE-26712: HCatMapReduceTest writes test files in project base directory instead of build directory. (apache#3738) (Chris Nauroth reviewed by Ayush Saxena)

HIVE-26726: Tinyint column with windowing fn crashes at runtime (Steve Carlin, reviewed by Aman Sinha, Krisztian Kasa)

HIVE-26680: Make CMV use Direct Insert Semantics (Sourabh Badhya, reviewed by Denys Kuzmenko, Laszlo Vegh)

Closes apache#3715

HIVE-26243: Add vectorized implementation of the 'ds_kll_sketch' UDAF (Alessandro Solimando, reviewed by Denys Kuzmenko, Zoltan Haindrich)

Closes apache#3317

HIVE-26761: Add result sorting to complex_alias.q (apache#3783) (Balazs Cseh reviewed by Laszlo Bodor)

HIVE-26759: Update SHOW COMPACTIONS query to support Postgres HMS (Akshat Mathur, reviewed by Denys Kuzmenko, Zsolt Miskolczi)

Closes 3782

HIVE-26765: Hive Ranger URL policy for insert overwrite directory denies access when fully qualified paths are passed (apache#3790) (Simhadri Govindappa, reviewed by Adam Szita)

Small refactors

Fix bug
InvisibleProgrammer pushed a commit to InvisibleProgrammer/hive that referenced this pull request Sep 11, 2023
Comment out classes to work on to be able to build the module

Refator TestCopyUtils.java

Before refactor: TestReplDumpTask

Refactor TestReplDumpTask.java

Before refactor: TestAtlasLoadTask

Refactor TestAtlasLoadTask.java

Refator TestRangerDumpTask.java

Before refactor: TestCompactionHeartbeatService

Refactor TestCompactionHeartbeatService.java

Before refactor: TestRetryable

Refactor TestRetryable.java

Before refactor: TestRangerLoadTask

Refactor: RangerLoadTask

Before refactor: TestAtlasDumpTask

Refactor: AtlasDumpTask

Before refactor: TestPrimaryToReplicaResourceFunction

Refactor TestPrimaryToReplicaResourceFunction

Before refactor: TestExportService

Refactor: TestExportService

HIVE-26522: Added test for HIVE-22033 regarding delegation token renewal (apache#3585)

HIVE-26676: Count distinct in subquery returning wrong results (Steve Carlin, reviewed by Alessandro Solimando, Aman Sinha, Krisztian Kasa)

HIVE-26736: Authorization failure for nested Views having WITH clause. (apache#3760). (Ayush Saxena, reviewed by Denys Kuzmenko)

HIVE-26628: Iceberg table is created when running explain ctas command (Krisztian Kasa, reviewed by Denys Kuzmenko)

HIVE-26734: Iceberg: Add an option to allow positional delete files without actual row data. (apache#3758). (Ayush Saxena, reviewed by Adam Szita, Denys Kuzmenko)

HIVE-26524: Use Calcite to remove sections of a query plan known never produces rows - ADDENDUM (Krisztian Kasa, reviewed by Stamatis Zampetakis)

HIVE-26740: HS2 makes direct connections to HMS backend DB due to Compaction/StatsUpdater (apache#3765) (Adam Szita, reviewed by Zhihua Deng)

HIVE-26631: Remove unused Thrift config parameters login.timeout and exponential.backoff.slot.length (xiuzhu9527 reviewed by Stamatis Zampetakis)

Closes apache#3672

HIVE-26747: Remove implementor from HiveRelNode (Krisztian Kasa, reviewed by Stamatis Zampetakis)

HIVE-26747: Remove implementor from HiveRelNode (Krisztian Kasa, reviewed by Stamatis Zampetakis) ADDENDUM

HIVE-26745: HPL unable to handle Decimal or null values in hplsql mode (apache#3769) (Adam Szita, reviewed by Attila Magyar and Denys Kuzmenko)

HIVE-26722: HiveFilterSetOpTransposeRule incorrectly prunes UNION ALL operands.  (apache#3748). (Alessandro Solimando, reviewed by Ayush Saxena, Simhadri Govindappa)

HIVE-26746: Request tracking: change to X-Request-ID header (apache#3770) (Laszlo Bodor reviewed by Zhihua Deng)

HIVE-26624: Set repl.background.enable on target after failover completion (Vinit Patni, reviewed by László Pintér, Teddy Choi)

Co-authored-by: vpatni <vpatni@cloudera.com>

HIVE-26712: HCatMapReduceTest writes test files in project base directory instead of build directory. (apache#3738) (Chris Nauroth reviewed by Ayush Saxena)

HIVE-26726: Tinyint column with windowing fn crashes at runtime (Steve Carlin, reviewed by Aman Sinha, Krisztian Kasa)

HIVE-26680: Make CMV use Direct Insert Semantics (Sourabh Badhya, reviewed by Denys Kuzmenko, Laszlo Vegh)

Closes apache#3715

HIVE-26243: Add vectorized implementation of the 'ds_kll_sketch' UDAF (Alessandro Solimando, reviewed by Denys Kuzmenko, Zoltan Haindrich)

Closes apache#3317

HIVE-26761: Add result sorting to complex_alias.q (apache#3783) (Balazs Cseh reviewed by Laszlo Bodor)

HIVE-26759: Update SHOW COMPACTIONS query to support Postgres HMS (Akshat Mathur, reviewed by Denys Kuzmenko, Zsolt Miskolczi)

Closes 3782

HIVE-26765: Hive Ranger URL policy for insert overwrite directory denies access when fully qualified paths are passed (apache#3790) (Simhadri Govindappa, reviewed by Adam Szita)

Small refactors

Fix bug
InvisibleProgrammer pushed a commit to InvisibleProgrammer/hive that referenced this pull request Sep 11, 2023
Comment out classes to work on to be able to build the module

Refator TestCopyUtils.java

Before refactor: TestReplDumpTask

Refactor TestReplDumpTask.java

Before refactor: TestAtlasLoadTask

Refactor TestAtlasLoadTask.java

Refator TestRangerDumpTask.java

Before refactor: TestCompactionHeartbeatService

Refactor TestCompactionHeartbeatService.java

Before refactor: TestRetryable

Refactor TestRetryable.java

Before refactor: TestRangerLoadTask

Refactor: RangerLoadTask

Before refactor: TestAtlasDumpTask

Refactor: AtlasDumpTask

Before refactor: TestPrimaryToReplicaResourceFunction

Refactor TestPrimaryToReplicaResourceFunction

Before refactor: TestExportService

Refactor: TestExportService

HIVE-26522: Added test for HIVE-22033 regarding delegation token renewal (apache#3585)

HIVE-26676: Count distinct in subquery returning wrong results (Steve Carlin, reviewed by Alessandro Solimando, Aman Sinha, Krisztian Kasa)

HIVE-26736: Authorization failure for nested Views having WITH clause. (apache#3760). (Ayush Saxena, reviewed by Denys Kuzmenko)

HIVE-26628: Iceberg table is created when running explain ctas command (Krisztian Kasa, reviewed by Denys Kuzmenko)

HIVE-26734: Iceberg: Add an option to allow positional delete files without actual row data. (apache#3758). (Ayush Saxena, reviewed by Adam Szita, Denys Kuzmenko)

HIVE-26524: Use Calcite to remove sections of a query plan known never produces rows - ADDENDUM (Krisztian Kasa, reviewed by Stamatis Zampetakis)

HIVE-26740: HS2 makes direct connections to HMS backend DB due to Compaction/StatsUpdater (apache#3765) (Adam Szita, reviewed by Zhihua Deng)

HIVE-26631: Remove unused Thrift config parameters login.timeout and exponential.backoff.slot.length (xiuzhu9527 reviewed by Stamatis Zampetakis)

Closes apache#3672

HIVE-26747: Remove implementor from HiveRelNode (Krisztian Kasa, reviewed by Stamatis Zampetakis)

HIVE-26747: Remove implementor from HiveRelNode (Krisztian Kasa, reviewed by Stamatis Zampetakis) ADDENDUM

HIVE-26745: HPL unable to handle Decimal or null values in hplsql mode (apache#3769) (Adam Szita, reviewed by Attila Magyar and Denys Kuzmenko)

HIVE-26722: HiveFilterSetOpTransposeRule incorrectly prunes UNION ALL operands.  (apache#3748). (Alessandro Solimando, reviewed by Ayush Saxena, Simhadri Govindappa)

HIVE-26746: Request tracking: change to X-Request-ID header (apache#3770) (Laszlo Bodor reviewed by Zhihua Deng)

HIVE-26624: Set repl.background.enable on target after failover completion (Vinit Patni, reviewed by László Pintér, Teddy Choi)

Co-authored-by: vpatni <vpatni@cloudera.com>

HIVE-26712: HCatMapReduceTest writes test files in project base directory instead of build directory. (apache#3738) (Chris Nauroth reviewed by Ayush Saxena)

HIVE-26726: Tinyint column with windowing fn crashes at runtime (Steve Carlin, reviewed by Aman Sinha, Krisztian Kasa)

HIVE-26680: Make CMV use Direct Insert Semantics (Sourabh Badhya, reviewed by Denys Kuzmenko, Laszlo Vegh)

Closes apache#3715

HIVE-26243: Add vectorized implementation of the 'ds_kll_sketch' UDAF (Alessandro Solimando, reviewed by Denys Kuzmenko, Zoltan Haindrich)

Closes apache#3317

HIVE-26761: Add result sorting to complex_alias.q (apache#3783) (Balazs Cseh reviewed by Laszlo Bodor)

HIVE-26759: Update SHOW COMPACTIONS query to support Postgres HMS (Akshat Mathur, reviewed by Denys Kuzmenko, Zsolt Miskolczi)

Closes 3782

HIVE-26765: Hive Ranger URL policy for insert overwrite directory denies access when fully qualified paths are passed (apache#3790) (Simhadri Govindappa, reviewed by Adam Szita)

Small refactors

Fix bug

Remove uneccessary constructor

Upgrading mockito in hive-exec
InvisibleProgrammer pushed a commit to InvisibleProgrammer/hive that referenced this pull request Sep 16, 2023
# This is the 1st commit message:

Start to refactor

Comment out classes to work on to be able to build the module

Refator TestCopyUtils.java

Before refactor: TestReplDumpTask

Refactor TestReplDumpTask.java

Before refactor: TestAtlasLoadTask

Refactor TestAtlasLoadTask.java

Refator TestRangerDumpTask.java

Before refactor: TestCompactionHeartbeatService

Refactor TestCompactionHeartbeatService.java

Before refactor: TestRetryable

Refactor TestRetryable.java

Before refactor: TestRangerLoadTask

Refactor: RangerLoadTask

Before refactor: TestAtlasDumpTask

Refactor: AtlasDumpTask

Before refactor: TestPrimaryToReplicaResourceFunction

Refactor TestPrimaryToReplicaResourceFunction

Before refactor: TestExportService

Refactor: TestExportService

HIVE-26522: Added test for HIVE-22033 regarding delegation token renewal (apache#3585)

HIVE-26676: Count distinct in subquery returning wrong results (Steve Carlin, reviewed by Alessandro Solimando, Aman Sinha, Krisztian Kasa)

HIVE-26736: Authorization failure for nested Views having WITH clause. (apache#3760). (Ayush Saxena, reviewed by Denys Kuzmenko)

HIVE-26628: Iceberg table is created when running explain ctas command (Krisztian Kasa, reviewed by Denys Kuzmenko)

HIVE-26734: Iceberg: Add an option to allow positional delete files without actual row data. (apache#3758). (Ayush Saxena, reviewed by Adam Szita, Denys Kuzmenko)

HIVE-26524: Use Calcite to remove sections of a query plan known never produces rows - ADDENDUM (Krisztian Kasa, reviewed by Stamatis Zampetakis)

HIVE-26740: HS2 makes direct connections to HMS backend DB due to Compaction/StatsUpdater (apache#3765) (Adam Szita, reviewed by Zhihua Deng)

HIVE-26631: Remove unused Thrift config parameters login.timeout and exponential.backoff.slot.length (xiuzhu9527 reviewed by Stamatis Zampetakis)

Closes apache#3672

HIVE-26747: Remove implementor from HiveRelNode (Krisztian Kasa, reviewed by Stamatis Zampetakis)

HIVE-26747: Remove implementor from HiveRelNode (Krisztian Kasa, reviewed by Stamatis Zampetakis) ADDENDUM

HIVE-26745: HPL unable to handle Decimal or null values in hplsql mode (apache#3769) (Adam Szita, reviewed by Attila Magyar and Denys Kuzmenko)

HIVE-26722: HiveFilterSetOpTransposeRule incorrectly prunes UNION ALL operands.  (apache#3748). (Alessandro Solimando, reviewed by Ayush Saxena, Simhadri Govindappa)

HIVE-26746: Request tracking: change to X-Request-ID header (apache#3770) (Laszlo Bodor reviewed by Zhihua Deng)

HIVE-26624: Set repl.background.enable on target after failover completion (Vinit Patni, reviewed by László Pintér, Teddy Choi)

Co-authored-by: vpatni <vpatni@cloudera.com>

HIVE-26712: HCatMapReduceTest writes test files in project base directory instead of build directory. (apache#3738) (Chris Nauroth reviewed by Ayush Saxena)

HIVE-26726: Tinyint column with windowing fn crashes at runtime (Steve Carlin, reviewed by Aman Sinha, Krisztian Kasa)

HIVE-26680: Make CMV use Direct Insert Semantics (Sourabh Badhya, reviewed by Denys Kuzmenko, Laszlo Vegh)

Closes apache#3715

HIVE-26243: Add vectorized implementation of the 'ds_kll_sketch' UDAF (Alessandro Solimando, reviewed by Denys Kuzmenko, Zoltan Haindrich)

Closes apache#3317

HIVE-26761: Add result sorting to complex_alias.q (apache#3783) (Balazs Cseh reviewed by Laszlo Bodor)

HIVE-26759: Update SHOW COMPACTIONS query to support Postgres HMS (Akshat Mathur, reviewed by Denys Kuzmenko, Zsolt Miskolczi)

Closes 3782

HIVE-26765: Hive Ranger URL policy for insert overwrite directory denies access when fully qualified paths are passed (apache#3790) (Simhadri Govindappa, reviewed by Adam Szita)

Small refactors

Fix bug

# This is the commit message apache#2:

Remove uneccessary constructor
tarak271 pushed a commit to tarak271/hive-1 that referenced this pull request Dec 19, 2023
… operands. (apache#3748). (Alessandro Solimando, reviewed by Ayush Saxena, Simhadri Govindappa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants