HIVE-26880: Upgrade Apache Directory Server to 1.5.7 for release 3.2. #3886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was already done on the master branch in HIVE-21836, authored by @zabetak and approved by @abstractdog . Would one of you be able to review? CC: @amanraj2520 , FYI on a branch-3 change. |
zabetak
reviewed
Dec 21, 2022
@zabetak , sorry, missed that. I've just pushed up the additional changes. The service/pom.xml change was only partially applicable, because there is no exclusion that needs to be removed on branch-3. |
zabetak
requested changes
Jan 2, 2023
zabetak
approved these changes
Jan 4, 2023
zabetak
pushed a commit
that referenced
this pull request
Jan 4, 2023
…eviewed by Stamatis Zampetakis) Closes #3886
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
branch-3 uses Apache Directory Server in some tests. It currently uses version 1.5.6. This version has a transitive dependency to a SNAPSHOT, making it awkward to build and release. We can upgrade to 1.5.7 to remove the SNAPSHOT dependency.
Why are the changes needed?
SNAPSHOT dependencies make local builds awkward and release build policies typically don't allow them.
Does this PR introduce any user-facing change?
No, Apache Directory Server is only used for tests.
How was this patch tested?
I built locally and confirmed tests.