-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIVE-27455: Iceberg: Set COLUMN_STATS_ACCURATE after writing stats for Iceberg tables #4440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgyrtkirk
added
tests pending
tests unstable
and removed
tests pending
tests unstable
labels
Jun 20, 2023
SourabhBadhya
force-pushed
the
HIVE-27455
branch
from
June 22, 2023 04:31
e6607eb
to
b6638b5
Compare
kgyrtkirk
added
tests pending
tests failed
and removed
tests unstable
tests pending
tests failed
labels
Jun 22, 2023
deniskuzZ
reviewed
Jun 22, 2023
ql/src/java/org/apache/hadoop/hive/ql/stats/ColStatsProcessor.java
Outdated
Show resolved
Hide resolved
SourabhBadhya
force-pushed
the
HIVE-27455
branch
from
June 22, 2023 11:59
b6638b5
to
57b919f
Compare
kgyrtkirk
added
tests unstable
tests pending
and removed
tests pending
tests unstable
labels
Jun 22, 2023
SourabhBadhya
force-pushed
the
HIVE-27455
branch
from
June 22, 2023 17:37
57b919f
to
8a16e35
Compare
kgyrtkirk
added
tests failed
tests pending
and removed
tests pending
tests failed
labels
Jun 22, 2023
SourabhBadhya
force-pushed
the
HIVE-27455
branch
from
June 23, 2023 14:19
8a16e35
to
c9d293a
Compare
kgyrtkirk
added
tests pending
tests failed
and removed
tests passed
tests pending
labels
Jul 10, 2023
SourabhBadhya
force-pushed
the
HIVE-27455
branch
from
July 11, 2023 07:56
c6c82d7
to
7e4d5e6
Compare
kgyrtkirk
added
tests unstable
tests pending
and removed
tests pending
tests unstable
labels
Jul 11, 2023
SourabhBadhya
force-pushed
the
HIVE-27455
branch
from
July 11, 2023 13:41
7e4d5e6
to
71a8653
Compare
SourabhBadhya
force-pushed
the
HIVE-27455
branch
from
July 11, 2023 13:53
71a8653
to
621c21d
Compare
deniskuzZ
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, pending tests
kgyrtkirk
added
tests pending
tests failed
and removed
tests unstable
tests pending
tests failed
labels
Jul 11, 2023
Kudos, SonarCloud Quality Gate passed! |
yeahyung
pushed a commit
to yeahyung/hive
that referenced
this pull request
Jul 20, 2023
…r Iceberg tables (Sourabh Badhya, reviewed by Denys Kuzmenko, Krisztian Kasa) Closes apache#4440
tarak271
pushed a commit
to tarak271/hive-1
that referenced
this pull request
Dec 19, 2023
…r Iceberg tables (Sourabh Badhya, reviewed by Denys Kuzmenko, Krisztian Kasa) Closes apache#4440
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Iceberg: Set COLUMN_STATS_ACCURATE after writing stats for Iceberg tables
Why are the changes needed?
Currently, we are writing the stats to puffin files but we are not setting the column stats accurate to the desired values.
The focus of the Jira would be to update the field whenever non-native tables update stats in their format.
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
Unit test