Add close() method to RestCatalog
#2403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a close() method to the RestCatalog class to properly close the HTTP session and release connection adapters. This implements proper resource cleanup for the REST catalog.
- Added the
close()method implementation that callsself._session.close() - Added comprehensive test coverage for the close functionality
- Included tests for both regular and SigV4-enabled catalog configurations
- Added context manager exception handling tests
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| pyiceberg/catalog/rest/init.py | Added the close() method implementation to RestCatalog class |
| tests/catalog/test_rest.py | Added comprehensive test suite for the new close functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2399
Rationale for this change
This PR introducs the implementation of
close()method to theRestCatalog.And add corresponding test case which following the test pattern in #2390
Are these changes tested?
Yes
Are there any user-facing changes?