BUG: Add assert spec id to requirements in spec update #2489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
approved these changes
Sep 22, 2025
There was a problem hiding this comment.
Great catch @gabeiglio, this indeed has the potential for a race-condition. Thanks for fixing this 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
When doing a commit that evolves the partition spec we are missing a requirement for asserting that the base default spec id has not changed.
Are these changes tested?
This change comes from reviewing #2479 which adds catalog tests to test the behavior of spec evolutions, specifically, one of the tests that commits a spec update conflict fails since does not raise
CommitFailedExceptionAre there any user-facing changes?
No.