Skip to content

Conversation

Gowthami03B
Copy link
Contributor

@Gowthami03B Gowthami03B commented Oct 1, 2025

Rationale for this change

Fixes #1905

Are these changes tested?

Are there any user-facing changes?

@Fokko
Copy link
Contributor

Fokko commented Oct 2, 2025

@lwfitzgerald I believe you're using multi-threading as well, are you seeing similar issues?

@lwfitzgerald
Copy link
Contributor

@lwfitzgerald I believe you're using multi-threading as well, are you seeing similar issues?

We're actually not calling pyiceberg from multiple threads. My recent fix in #2495 was to correct multi-threading internal to pyiceberg (through the ExecutorManager ThreadPoolExecutor).

@Fokko More generally, are pyiceberg.table.Tables intended to be thread-safe?

@Fokko
Copy link
Contributor

Fokko commented Oct 2, 2025

@lwfitzgerald Got it, thanks for chiming in here. And yes, Table should be thread safe.

Moving this forward @Gowthami03B Thanks for fixing this 👍

@Fokko Fokko merged commit dbe2486 into apache:main Oct 2, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cachetools exceptions when reading table metadata
3 participants