Skip to content

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Oct 6, 2025

Rationale for this change

Resolves #2572

Are these changes tested?

Are there any user-facing changes?

@Fokko Fokko requested a review from kevinjqliu October 6, 2025 22:13
Copy link
Contributor

@rambleraptor rambleraptor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at all of those # type: ignore statements going away! This looks awesome

Copy link
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

assert isinstance(literal(datetime.date.today()), DateLiteral)


def test_to_json() -> None:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevinjqliu kevinjqliu merged commit ce28e00 into apache:main Oct 7, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make Literals extend from IcebergRootModel

3 participants