Skip to content

[Bug Fix] all TimeTransforms for falsey values #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

sungwy
Copy link
Collaborator

@sungwy sungwy commented Jan 18, 2024

Following up on @HonahX 's comment on #276

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this also got me more than once 😄

@sungwy
Copy link
Collaborator Author

sungwy commented Jan 18, 2024

CI failure related to: #279

@Fokko
Copy link
Contributor

Fokko commented Jan 18, 2024

@syun64 Thanks, let me poke someone to get it in 👍

@sungwy
Copy link
Collaborator Author

sungwy commented Jan 18, 2024

No problem, and thank you! :)

@Fokko
Copy link
Contributor

Fokko commented Jan 18, 2024

@syun64 The other PR is in 👍 Can you rebase?

@sungwy
Copy link
Collaborator Author

sungwy commented Jan 18, 2024

of course!

@Fokko Fokko requested a review from HonahX January 18, 2024 20:59
@Fokko Fokko added this to the PyIceberg 0.6.0 release milestone Jan 18, 2024
Copy link
Contributor

@HonahX HonahX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the quick fix.

@sungwy
Copy link
Collaborator Author

sungwy commented Jan 18, 2024

Thank you for the reviews @Fokko @HonahX . Could I ask for your help in merging it in? :)

@HonahX
Copy link
Contributor

HonahX commented Jan 19, 2024

@syun64 Sorry I was interrupted by other things. Merging!

@HonahX HonahX merged commit e1018e5 into apache:main Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants