StructType field optional by default
#592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MehulBatra
changed the title
required optional by defaultoptional by default
Fokko
reviewed
Apr 10, 2024
There was a problem hiding this comment.
Looks good @MehulBatra Left one small suggestion.
Could you also remove required=False from mkdocs/docs/api.md. Since this is now default, I think we should remove it to make the docs less verbose.
On it, pushing changes for the same. |
MehulBatra
force-pushed
the
nested_field_struct_type
branch
from
87aca9d to
e354f86
Compare
MehulBatra
force-pushed
the
nested_field_struct_type
branch
from
e354f86 to
9592d12
Compare
Fokko
approved these changes
Apr 17, 2024
Fokko
reviewed
Apr 17, 2024
|
@MehulBatra I've removed an unrelated change, I think #612 addresses the issue that you ran into |
sounds good! |
|
Thanks for fixing this @MehulBatra Much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.