refactor(test): remove MockLocationGenerator and its usages (#1645) #1663
+73
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pushcoder
force-pushed
the
remove-MockLocationGenerator
branch
from
691e562 to
ac65efd
Compare
pushcoder
force-pushed
the
remove-MockLocationGenerator
branch
from
ac65efd to
9f4651d
Compare
liurenjie1024
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Refactoring. Keep only one source of location generation. So remove MockLocationGenerator and use DefaultLocationGenerator when table location is available/user given.
Are these changes tested?
Yes. Changed UT of MockLocationGenerator to DefaultLocationGenerator(Using newly added method)