Skip to content

ci: Don't run CI on unrelated changes #1686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2025
Merged

ci: Don't run CI on unrelated changes #1686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/bindings_python_ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,11 @@ on:
branches:
- main
pull_request:
branches:
- main
paths:
- ".github/workflows/bindings_python_ci.yml"
- "bindings/python/**"
- "crates/iceberg/**"
- "crates/integrations/datafusion/**"
Comment on lines +25 to +29
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crates/iceberg/ and crates/integrations/datafusion/ since we depend on those here

iceberg-rust/bindings/python/Cargo.toml

Lines 33 to 37 in 29a01bc

[dependencies]
arrow = { version = "55.1", features = ["pyarrow", "chrono-tz"] }
iceberg = { path = "../../crates/iceberg" }
pyo3 = { version = "0.24.1", features = ["extension-module", "abi3-py39"] }
iceberg-datafusion = { path = "../../crates/integrations/datafusion" }

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect? If we changed Cargo.toml, we should also run ci? cc @manuzhang @kevinjqliu

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea great catch. @manuzhang maybe we can use the similar logic to .github/workflows/ci.yml


concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
Expand Down
16 changes: 15 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,21 @@ on:
- main
pull_request:
branches:
- main
- '**' # Include all files and directories in the repository by default.
- '!.github/workflows/**' # Exclude all workflow files
- '.github/workflows/ci.yml' # except the current file.
- '!.github/actions/**' # Exclude custom actions
- '!.github/ISSUE_TEMPLATE/**' # Exclude files and directories that don't impact tests or code like templates, metadata, and documentation.
- '!scripts/**'
- '!website/**'
- '!.asf.yml'
- '!.gitattributes'
- '!.gitignore'
- '!CONTRIBUTING.md'
- '!CHANGELOG.md'
- '!LICENSE'
- '!NOTICE'
- '!README.md'

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/website.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,9 @@ on:
branches:
- main
pull_request:
branches:
- main
paths:
- ".github/workflows/website.yml"
- "website/**"

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
Expand Down
Loading