Skip to content

Conversation

kevinjqliu
Copy link
Contributor

@kevinjqliu kevinjqliu commented Sep 17, 2025

Which issue does this PR close?

Follow up to #1683

What changes are included in this PR?

For nightly builds, we override the version to with the format 0.7.0.dev{timestamp} and Cargo doesn't like that (see failed github action run)
Instead, we have to read the version from Cargo.toml and override the version in pyproject.toml

Are these changes tested?

Ran github action on my forked repo, https://github.com/kevinjqliu/iceberg-rust/actions/runs/17807059563
Manually checked the artifacts and verified the versions are correct

@kevinjqliu kevinjqliu requested a review from Fokko September 17, 2025 18:31
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow up @kevinjqliu

@Fokko Fokko merged commit 2715d52 into apache:main Sep 18, 2025
17 checks passed
@kevinjqliu kevinjqliu deleted the kevinjqliu/fix-nightly-build branch September 18, 2025 13:57
@kevinjqliu
Copy link
Contributor Author

nice! i manually triggered a run and it was successful
https://github.com/apache/iceberg-rust/actions/runs/17831067664
https://test.pypi.org/project/pyiceberg-core/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants