Skip to content

chore: Bump the Java integration test to 1.10.0 #1701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 22, 2025
Merged

chore: Bump the Java integration test to 1.10.0 #1701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d572f5
chorse: Bump the Java integration test to 1.10.0
Fokko Sep 22, 2025
b2104bd
The deletes are combined
Fokko Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/integration_tests/testdata/spark/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ WORKDIR ${SPARK_HOME}

ENV SPARK_VERSION=3.5.6
ENV ICEBERG_SPARK_RUNTIME_VERSION=3.5_2.12
ENV ICEBERG_VERSION=1.6.0
ENV ICEBERG_VERSION=1.10.0

RUN curl --retry 5 -s -C - https://dlcdn.apache.org/spark/spark-${SPARK_VERSION}/spark-${SPARK_VERSION}-bin-hadoop3.tgz -o spark-${SPARK_VERSION}-bin-hadoop3.tgz \
&& tar xzf spark-${SPARK_VERSION}-bin-hadoop3.tgz --directory /opt/spark --strip-components 1 \
Expand Down
2 changes: 1 addition & 1 deletion crates/integration_tests/tests/shared_tests/read_positional_deletes.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ async fn test_read_table_with_positional_deletes() {

// Scan plan phase should include delete files in file plan
// when with_delete_file_processing_enabled == true
assert_eq!(plan[0].deletes.len(), 2);
assert_eq!(plan[0].deletes.len(), 1);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deletes are now automatically compacted to avoid read amplification 👍


// we should see two rows deleted, returning 10 rows instead of 12
let batch_stream = scan.to_arrow().await.unwrap();
Expand Down
Loading